Skip to main content
Topic: [ADDON] Nofollow attribute for external links (Read 4556 times) previous topic - next topic - Topic derived from Request - Nofollow at...
0 Members and 1 Guest are viewing this topic.

Re: [ADDON] Nofollow attribute for external links

Reply #15
Interesting... I didn't follow this before, so I'm parking in and will test this later.

Re: [ADDON] Nofollow attribute for external links

Reply #16
It works Ahrasis.  Highlight the keywords the poster is linking to, then right click to bring up  "inspect element" using FF.  Then it shows the link is a nofollow!  Why should I be giving away free link juice?  No more!

Re: [ADDON] Nofollow attribute for external links

Reply #17
Is it a permission based? I haven't look into the code yet.

Re: [ADDON] Nofollow attribute for external links

Reply #18
I feel email don't really have any reason to be nofollow.
The only option is to mask them somehow, but add the nofollow attribute is not of great help.
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON] Nofollow attribute for external links

Reply #19
I am getting some errors in elkarte log:
Undefined index: host
sources/subs/NoFollow.integrate.php Line: 174

line 174 is:
Code: [Select]
			if (substr($parsed['host'], -strlen($valid_domain)) === $valid_domain)

The errors are related to some topics and in search results. Any suggestion to solve this?
sorry for my bad english

Re: [ADDON] Nofollow attribute for external links

Reply #20
Do you have the URLs of the searches?
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON] Nofollow attribute for external links

Reply #21
Code: [Select]
https://www.sharkracingclub.it/index.php?action=search;sa=results;params=eJwtzksOwjAMBNC7sGEzQs2_nKZKE4sWQoPSFISUw-Oibkbjt7Dt49svgWI7t66d2lj2ZhyMhoHSUAoSQkFYSAGhYQUsp4MTkBZOwUJraAnTw0FZCAHN2UFdoVh69JpXr1P-DCE_X4kq8ZGdtvFOoQ55Sd9DcqncCiX6_3XQEOfCHGkNu5AvYeJ5nXx5FB_m5RbSNl7m-gO70UGj;start=60

and a topic where I see the error sharkracingclub.it/index.php?topic=2944.15
sorry for my bad english

Re: [ADDON] Nofollow attribute for external links

Reply #22
And no other errors?
That's strange... :-\

Memo to self: the code should ignore the www.
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON] Nofollow attribute for external links

Reply #23
I cleared the erros, I just did a search for tag (img] and I get another error:
type of error: Undefined
Undefined index: host
https://www.sharkracingclub.it/index.php?action=search;sa=results
 File: /sources/subs/NoFollow.integrate.php
Line: 177


Tomorrow I will look better in the other forum, there I got more errors.
sorry for my bad english

Re: [ADDON] Nofollow attribute for external links

Reply #24
What version of php?
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON] Nofollow attribute for external links

Reply #25
temporary I switched to 5.4, but usually I use 5.6
sorry for my bad english

Re: [ADDON] Nofollow attribute for external links

Reply #26
Exactly what php 5.4 version is it?
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON] Nofollow attribute for external links

Reply #27
5.4.45  O:-)
sorry for my bad english

Re: [ADDON] Nofollow attribute for external links

Reply #28
*headscratch*
And with 5.6 it was working?

 emanuele is temped to blame php and declare 5.6 the minimum version. xD

Seriously: I have to look into it.
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON] Nofollow attribute for external links

Reply #29
with php5.4 I only got 2 errors in the last 8 hours
Guest
Type of error: Undefined
 Undefined index: host
https://www.sharkracingclub.it/index.php?topic=2944.15
File: /srv/users/serverpilot/apps/sharkracingclub/public/sources/subs/NoFollow.integrate.php
Line: 177


I switch now to php5.6 to see if I get other errors
sorry for my bad english