[ADDON] Nofollow attribute for external links

[ADDON] Nofollow attribute for external links Started by emanuele · June 05, 2016, 05:09:53 pm · Read 58999 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic - Topic derived from Request - Nofollow attribute ...

Re: [ADDON] Nofollow attribute for external links

Reply #30 – March 20, 2017, 08:34:52 am

i found some errors in elkarte log, all of them are related to this topic http://www.skodaclub.it/index.php?topic=4799.0
i am using php 5.6

8: undefined index: host
file: /sources/subs/nofollow.integrate.php
line: 177

the strange thing is there is no link on that page, only a youtube video. could be this?

Re: [ADDON] Nofollow attribute for external links

Reply #31 – March 22, 2017, 03:45:30 pm

another stupid error. $:-\$

in nofollow.integrate.php, change:

Code: [Select]

$message = preg_replace_callback('~<a href="(.*?)" class="bbc_link" rel="nofollow"(?: target=".*?")?>~', array(self::$instance, 'replace_callback'), $message);

to:

Code: [Select]

$message = preg_replace_callback('~<a href="([^>]*?)" class="bbc_link" rel="nofollow"(?: target="_?\w+")?>~', array(self::$instance, 'replace_callback'), $message);

that should do.

Re: [ADDON] Nofollow attribute for external links

Reply #32 – March 22, 2017, 08:13:36 pm

thank you, no more errors from that topic

Re: [ADDON] Nofollow attribute for external links

Reply #33 – September 19, 2017, 06:45:03 pm

i just installed this on 1.1 rc2, it installs without errors, but it's not working. if i publish a link like

Code: [Select]

[url=https://www.google.it]google.it[/url]

becames:

Code: [Select]

[url url=https://www.google.it nofollow=dofollow]google.it[/url]

but there is no link visible, only text.

Re: [ADDON] Nofollow attribute for external links

Reply #34 – December 17, 2017, 05:07:31 pm

@emanuele‍ do you have any plans to update this addon for elkarte 1.1? thank you

Re: [ADDON] Nofollow attribute for external links

Reply #35 – April 29, 2020, 02:17:44 pm

is there any improvement?

i installed in version 1.1.6 does not add nofolow

Re: [ADDON] Nofollow attribute for external links

Reply #36 – April 29, 2020, 06:27:12 pm

the add-on is not compatible with elkarte 1.1

Re: [ADDON] Nofollow attribute for external links

Reply #37 – May 15, 2020, 02:24:33 pm

hi,

@emanuele

can you give information about working with code editing?

a detailed revision is required

Re: [ADDON] Nofollow attribute for external links

Reply #38 – May 20, 2020, 02:21:35 am

hmm... bbc parser.
from @radu81 comment i'd say the problem is in the parsing, though right not i'm not entirely sure why it should not work (apart from the fact it still uses create_function and messes with http/https).
this evening i'll try to have a look.

Re: [ADDON] Nofollow attribute for external links

Reply #39 – May 20, 2020, 03:58:32 pm

i tried, honestly i didn't test it at all. from this to time this happens to work out well, not always. xd

Re: [ADDON] Nofollow attribute for external links

Reply #40 – May 21, 2020, 02:55:20 am

thanks @emanuele works, there is a problem but also affects main site links

Code: [Select]

<a href="https://MAIN-SITE.com" class="bbc_link" rel="noopener noreferrer nofollow" target="_blank">"https://MAIN-SITE.com</a>


<a href="https://EXTERNAL-SITE.com" class="bbc_link" rel="noopener noreferrer nofollow" target="_blank">https://EXTERNAL-SITE.com</a>

Re: [ADDON] Nofollow attribute for external links

Reply #41 – May 21, 2020, 07:28:51 am

i guess i don't like to do assumptions, that's likely why there is a "white list" setting in the admin panel.

Re: [ADDON] Nofollow attribute for external links

Reply #42 – May 21, 2020, 11:30:43 am

thanks. i found the settings but after saving it gave error

click check box (internal site) and add one site link white link area (https://www.site.com) save setting

error setting page appears;

Code: [Select]

implode(): Invalid arguments passed

and the setting page always gives the same error

i can access the settings page when i uninstall the plugin

it again error page appears when installing the plugin again

Re: [ADDON] Nofollow attribute for external links

Reply #43 – May 23, 2020, 05:39:54 am

there should be also something else along with the error, like the file and the row number.

Re: [ADDON] Nofollow attribute for external links

Reply #44 – May 23, 2020, 06:29:17 am

hi,

file: /sources/subs/nofollow.integrate.php
line: 142

a different error appears click "back" button;