Skip to main content ↑ ↓
Unsure if it's a bug? Started by badmonkey · · Read 36493 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

Re: Unsure if it's a bug?

Reply #15 –

Well I'm finally using the AIR addon on a live 1.1.6 and its a bug for sure in the resize code.

I've tried a couple of fixes, hopping it would be easy, but same error is occurring.  I think it is a sort of race condition caused by the displaying of the little icon in the post panel, to get that it has to pass the resize code before the post and something is not done or cleared after that such that when you hit post and it does it again, it sometimes goes boom!

Well at least you know you were not crazy, well about this bug at least ;)

Re: Unsure if it's a bug?

Reply #16 –

Quote from: Spuds – Well at least you know you were not crazy, well about this bug at least ;)
 
 Quite certain I was, and still am, a bit off the mark. ;D

Cool, at least it's a step in the right direction. Many thanks Spuds!

Re: Unsure if it's a bug?

Reply #17 –

OK who's ready for a test ...

Replace your current file in the subs directory with this one and lets see what happens. 

The previous resize code was triggered during the ulattach operation, that is the action that creates the icon/thumb images shown in the post attachment area.  This update skips that action and should only run when the user actually posts.  So if we did have a race condition or some file lock contention, then this should fix that.   hopes

Testing will tell !
 

Re: Unsure if it's a bug?

Reply #18 –

Quote from: Spuds – OK who's ready for a test ...

Replace your current file in the subs directory with this one and lets see what happens. 

The previous resize code was triggered during the ulattach operation, that is the action that creates the icon/thumb images shown in the post attachment area.  This update skips that action and should only run when the user actually posts.  So if we did have a race condition or some file lock contention, then this should fix that.  hopes

Testing will tell !
 
 The patch has been loaded on my 3 sites and released to the wolves. A couple of quick test uploads gave affirmative results. Will check in again with further results! Many thanks Spuds!!  You da man!

Re: Unsure if it's a bug?

Reply #19 –

Thanks for putting this to the test :D you da man and I appreciate the effort..

Re: Unsure if it's a bug?

Reply #20 –

A few days have passed while a few dozen images have been uploaded. So far there are no related errors in the log, and no reports of failed uploads. Seems logical the fix is good! Thanks again Spuds!

Re: Unsure if it's a bug?

Reply #21 –

Great to hear

I've also been beating on it with multiple large (10mb) files and only had a single hit in the error log, so I feel my assumption about what was occurring was correct.  I intend to do another look at exactly where the absolute best place is to run (meaning on the first attach action or the actual post action) but for now at least we have a direction to refine.

Thanks again for the testing!

Re: Unsure if it's a bug?

Reply #22 –

This thread deserves an update. Several months have floated by. The world has been a rollercoaster. Our lives have been impacted by a virus "they" say originated from an old bat, though it's unclear how Nancy Pelosi could be involved.

Spuds, your work definitely improved the situation. However, the error still occurred on occasion. Strangely, it seemed most prominent when attaching smaller file size images. Odd for sure. And zero predictability regarding the phenomenon.

Then through unrelated tinkering I discovered the likely root cause. nginx directio does not play well with inlining attachments. If you use nginx it is probably best to turn directio OFF. At least that is the current supporting information. Time will tell.....

.....if anyone has other advice let's hear it!