Skip to main content
Topic: [1.1.5] Cannot edit an existing ban trigger (Read 864 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

[1.1.5] Cannot edit an existing ban trigger

This is after applying the fix from my previous bug report about ban triggers. It mentions something about invalid arguments to a foreach().

I was attempting to fix an email ban trigger, which was set to just the domain, instead of *@domain

Re: [1.1.5] Cannot edit an existing ban trigger

Reply #1
@kode54

If you could edit ManageBans.controller.php (in sources/admin) line 806

Code: (current) [Select]
			$dummy['ban_suggestions'] = array_shift($this->_req->post->ban_suggestions);
Code: (new) [Select]
			$dummy['ban_suggestions'] = (array) array_shift($this->_req->post->ban_suggestions);

Just adding that (array) and let me know if that fixes the problem and if you see any other side effects.

Thanks
Squish squish. squish, squish, squish.
Find a bug,
Make a wish.

Re: [1.1.5] Cannot edit an existing ban trigger

Reply #2
Let's keep #3320 open until this is fixed?
Bugs creator.
Features destroyer.
Template killer.

 

Re: [1.1.5] Cannot edit an existing ban trigger

Reply #3
Agree, I'll add the above fix to the PR, I think that will be all that is needed but will wait for kode54 to confirm.
Squish squish. squish, squish, squish.
Find a bug,
Make a wish.