Skip to main content
Topic: advice (Read 1233 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

advice

Oook!

I started playing (again...yeah I know I'm boring) with the ManageBans.php.
At the moment it looks like this:
https://github.com/emanuele45/playpen/blob/banEdit/Sources/ManageBans.php

It looks a bit better then before (I think), but it still seems a bit ugly...

So the questions are:
1) would make sense to move some functions somewhere else? (the only one used outside of this file seems to be updateBanMembers)
2) the management of bans is another piece of code where the action to take highly depends on the POSTed data. Is there anything to do about it?
Bugs creator.
Features destroyer.
Template killer.