Php7.4 compatibality

Php7.4 compatibality Started by ahrasis · August 24, 2020, 09:33:02 pm · Read 25390 times 0 Members and 2 Guests are viewing this topic. previous topic - next topic

Php7.4 compatibality

August 24, 2020, 09:33:02 pm

@emanuele mentioned that current ea is not fully php7.4 compatible and i never fully tested this though i did try running it on php7.4.

are there a lot of things to do to make it fully compatible to php7.4 or should we just stick to using ea with php7.2?

eol of php7.2 at 30/11/2020 is mentioned here:
https://www.php.net/supported-versions.php

Re: Php7.4 compatibality

Reply #1 – August 26, 2020, 04:53:42 am

i am using 7.3 and it works, i do have some errors on elkarte log, some related to mods and probably some related to elkarte.

i can use my 2 forums and report all the errors i got, if there are plans to make it compatible with 7.4.

Re: Php7.4 compatibality

Reply #2 – September 04, 2020, 10:11:14 pm

i think that would be a good thing to do.

everyone is obviously going to have to move to at least php 7.3 soon, so if there are some errors which are easy to patch it'd be good to have a list. if it can be made to work without errors on 7.3 pretty quickly, that will give another year of leeway before 7.3 hits eol.

Re: Php7.4 compatibality

Reply #3 – September 11, 2020, 10:29:30 am

just cleared my log, but in the next days i will report them.

Re: Php7.4 compatibality

Reply #4 – September 16, 2020, 02:25:08 pm

7.4 if i remember correctly requires few bits.
i think the board index itself is broken in 7.4 (at least for 1.1, 2.0 should have been fixed a while ago), but it should be a minor change to fix.

Re: Php7.4 compatibality

Reply #5 – November 30, 2020, 05:21:24 am

i think the sooner the fixes are released, the better. today is the last day of php7.2 security support anyway.

i believe php8.0 has also been released so ea compatible to it is also another plus.

Re: Php7.4 compatibality

Reply #6 – December 06, 2020, 02:32:37 pm

ehh... yeah...
i'm wasting so much time watching youtube i wouldn't have never imagined a year ago. really.
i have to find a way to shut it down for good... ;^_^

Re: Php7.4 compatibality

Reply #7 – December 06, 2020, 06:33:21 pm

i'm glad i'm not the only one wasting my time on youtube videos lol ... amazing how that can suck you in

Re: Php7.4 compatibality

Reply #8 – December 08, 2020, 03:44:39 pm

i've started to work on the 7.4 issues ... fixed a few files, mostly importantly the bbc parser.

anyway if anyone is using 7.4 and can point me at pages / actions that have errors, then do so here, thanks!

Re: Php7.4 compatibality

Reply #9 – December 09, 2020, 02:50:51 am

just quicly switched to php 7.4 and i get this in elkarte error log at any page refresh

guest
tipo di errore: generale
notice: trying to access array offset on value of type null
file: /sources/browserdetector.class.php
line: 249

247:	if (!isset($this->_browsers['possibly_robot']))
248:	{
249:	if ($user_info['possibly_robot']) {
250:	// this isn't meant to be reliable, it's just meant to catch most bots to prevent phpsessid from showing up.
251:	$this->_browsers['possibly_robot'] = !empty($user_info['possibly_robot']);

Re: Php7.4 compatibality

Reply #10 – December 09, 2020, 09:22:05 am

i think that may be a small bug from sp as i can't reproduce it on my local ... but i added a fix in elkarte for those lazy addon writers

just change that 249 line to be

Code: [Select]

if (isset($user_info['possibly_robot'])) {

Re: Php7.4 compatibality

Reply #11 – December 10, 2020, 08:43:58 am

this solved that annoying error, thanks spuds

now:
tipo di errore: generale
notice: trying to access array offset on value of type bool
file: /sources/subs/drafts.subs.php
line: 458

Code: [Select]

	if ($draft_info['is_usersaved'] == 1)

Re: Php7.4 compatibality

Reply #12 – December 10, 2020, 10:13:33 am

that one i saw

... i recall that the is_usersaved flag was not being set when using the pm system, so the update was to add it to that. there are a few lines involved. https://github.com/Spuds/Elkarte/commit/a745cf7c30bb628047842bc589378fd7facd9bbc

Re: Php7.4 compatibality

Reply #13 – December 10, 2020, 05:57:32 pm

seems to be solved, that error disapperead

i am using php 7.4 on my small forum hyundairacing.it and i am testing first the most used and important tasks, like registration, posting, search, etc...
i just did a new registration, and i got this on elk log:

guest
tipo di errore: generale
notice: trying to access array offset on value of type bool
/index.php?action=auth;sa=check;member=1025
file: /sources/load.php
line : 294

293:	// if it was at least five hours ago...
294:	if ($visitopt['poster_time'] < time() - 5 * 3600)
295:	{

the registration worked fine

@spuds‍ i know it's not your add-on, and i doubt bugo will answer, but do you have any idea on this error?
https://github.com/dragomano/Optimus/issues/32

Re: Php7.4 compatibality

Reply #14 – December 10, 2020, 06:51:30 pm

for that one, changing line 294 to be:

Code: [Select]

			if ($visitOpt === false || $visitOpt['poster_time'] < time() - 5 * 3600)

should resolve that.

i'll try to take a look at bugo's code

eta: that optimus error should be fixed by chanign line 290 to:

Code: [Select]

$context['insert_after_template'] .= implode(',', $list_item);