Skip to main content
Topic: Which file should contain the string "insert"? (Read 215 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Which file should contain the string "insert"?

Which file should contain the string "insert"? I can't find it for translation.
X
Community of forum owners on any forum engine (сообщество владельцев форумов на любом форумном движке) https://forumovod.ru

Re: Which file should contain the string "insert"?

Reply #1
I think it's Line 50 of Editor.english.php:

Code: [Select]
$editortxt['Insert'] = 'Insert';
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Which file should contain the string "insert"?

Reply #2
Not that, I have that line translated and I still see the english text.

edit
it's hardcoded into /themes/default/Post.template.php at line 453
Code: [Select]
						<input type="button" class="button" value="insert">

I move this topic to Bug Reports
sorry for my bad english

Re: Which file should contain the string "insert"?

Reply #3
I think it's Line 50 of Editor.english.php
This is not such a string.

edit
it's hardcoded into /themes/default/Post.template.php at line 453
Code: [Select]
						<input type="button" class="button" value="insert">
Yes, this is exactly what you need. Thanks.
Community of forum owners on any forum engine (сообщество владельцев форумов на любом форумном движке) https://forumovod.ru


Re: Which file should contain the string "insert"?

Reply #5
ARG!
Dang.

https://github.com/elkarte/Elkarte/commit/029ca2c267ebf3806253da74e816c44400a8f5ee

The code is the difference between insert and Insert. Is this correct? Or another language file?
Post.template.php
Code: [Select]
<input type="button" class="button" value="' . $txt['insert'] . '">
Editor.english.php
Code: [Select]
$editortxt['Insert'] = 'Insert';
Community of forum owners on any forum engine (сообщество владельцев форумов на любом форумном движке) https://forumovod.ru

 

Re: Which file should contain the string "insert"?

Reply #6
The commit on GitHub shows the string going in themes/default/languages/english/Post.english.php ;)

Although it does seem a bit silly to have exactly the same string called in two separate files. I can see that confusing someone sooner or later. I would think Editor.******.php should be able to handle it. Better grumble at Ema.

Or you could just try it your way. If it works, that's even better.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Which file should contain the string "insert"?

Reply #7
ARG!
Dang.

https://github.com/elkarte/Elkarte/commit/029ca2c267ebf3806253da74e816c44400a8f5ee

The code is the difference between insert and Insert. Is this correct? Or another language file?
Yes.
Green: add
Pink: remove

Post.template.php
Code: [Select]
<input type="button" class="button" value="' . $txt['insert'] . '">
Editor.english.php
Code: [Select]
$editortxt['Insert'] = 'Insert';
It's not Editor.english.php, it's Post.english.php and it's not $editortxt, but $txt. ;)
You see the file names at the beginning of each code block.
Bugs creator.
Features destroyer.
Template killer.

Re: Which file should contain the string "insert"?

Reply #8
It's not Editor.english.php, it's Post.english.php and it's not $editortxt, but $txt. ;)
You see the file names at the beginning of each code block.

This is understandable. But logically it should be in Editor.english.php, not in Post.english.php.
Community of forum owners on any forum engine (сообщество владельцев форумов на любом форумном движке) https://forumovod.ru

Re: Which file should contain the string "insert"?

Reply #9
Well, I'm pretty sure it has to be in Post.english.php, but if you know the logic behind the files in Elk, more than I do, then be my guest.
Bugs creator.
Features destroyer.
Template killer.