Skip to main content
Topic: [bug] - moved marked as "new" even after click on them (Read 1527 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

[bug] - moved marked as "new" even after click on them

Sort of regressions: I thought I fixed this quite a long time ago...
Bugs creator.
Features destroyer.
Template killer.

Re: [bug] - moved marked as "new" even after click on them

Reply #1
You probably did. :D
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [bug] - moved marked as "new" even after click on them

Reply #2
Should be easy to fix again then  8)
Squish squish. squish, squish, squish.
Find a bug,
Make a wish.


Re: [bug] - moved marked as "new" even after click on them

Reply #4
I'll take the blame as long as you fix it :P
Squish squish. squish, squish, squish.
Find a bug,
Make a wish.

Re: [bug] - moved marked as "new" even after click on them

Reply #5
I have already 17 branches... (and this will be the 18th)
 emanuele hates git.
Bugs creator.
Features destroyer.
Template killer.

Re: [bug] - moved marked as "new" even after click on them

Reply #6
I think this should work:
Code: [Select]
	// Is this a moved topic that we are redirecting to?
if (!empty($topicinfo['id_redirect_topic']))
{
markTopicsRead(array($user_info['id'], $topic, $topicinfo['id_last_msg']), $topicinfo['new_from'] !== 0);
redirectexit('topic=' . $topicinfo['id_redirect_topic'] . '.0');
}
in Display.php about line 133
Bugs creator.
Features destroyer.
Template killer.

Re: [bug] - moved marked as "new" even after click on them

Reply #7
I have already 17 branches... (and this will be the 18th)
 emanuele hates git.
Join the club. Git is a total PITA.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [bug] - moved marked as "new" even after click on them

Reply #8
I have already 17 branches... (and this will be the 18th)
 emanuele hates git.

23... with more than 1/2 with a single theme...  ::)
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: [bug] - moved marked as "new" even after click on them

Reply #9
I have already 17 branches... (and this will be the 18th)
 emanuele hates git.

Hey! It's Smart (tm): look, it didn't even blink, when I committed your fix (couple minutes ago) and then merged your PR with it again. :D
Smart git is smart. :P
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: [bug] - moved marked as "new" even after click on them

Reply #10
60 in SMF repo... (most of them I don't even know why I create the branch)
I should really delete some of them... LOL
Bugs creator.
Features destroyer.
Template killer.