Skip to main content
Topic: "new" icon and long subjects (Read 1439 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

"new" icon and long subjects

When the subject is long, the "new" icon forces it to a new line (see attachment).
I did some experiments, and the only way I found to fix it is move the icon inside the h4:
Code: (MessageIndex.template.php) [Select]
					<div class="topic_name" ', (!empty($topic['quick_mod']['modify']) ? 'id="topic_' . $topic['first_post']['id'] . '"  ondblclick="oQuickModifyTopic.modify_topic(\'' . $topic['id'] . '\', \'' . $topic['first_post']['id'] . '\');"' : ''), '>
<h4>';

// Is this topic new? (assuming they are logged in!)
if ($topic['new'] && $context['user']['is_logged'])
echo '
<a class="new_posts" href="', $topic['new_href'], '" id="newicon' . $topic['first_post']['id'] . '">' . $txt['new'] . '</a>';

echo '
', $topic['is_sticky'] ? '<strong>' : '', '<span class="preview" title="', $topic[(!empty($settings['message_index_preview']) && $settings['message_index_preview'] == 2 ? 'last_post' : 'first_post')]['preview'], '"><span id="msg_' . $topic['first_post']['id'] . '">', $topic['first_post']['link'], ($context['can_approve_posts'] && !$topic['approved'] ? '&nbsp;&nbsp;<em><img src="' . $settings['images_url'] . '/admin/post_moderation_moderate.png" style="width:16px" alt="' . $txt['awaiting_approval'] . '" title="' . $txt['awaiting_approval'] . '" />(' . $txt['awaiting_approval'] . ')</em>' : ''), '</span></span>', $topic['is_sticky'] ? '</strong>' : '', '
</h4>

Is it acceptable?
Bugs creator.
Features destroyer.
Template killer.

Re: "new" icon and long subjects

Reply #1
I added the commit to this PR: https://github.com/elkarte/Elkarte/pull/1187

In particular:
https://github.com/emanuele45/Dialogo/commit/acd4370b72e4d20df35bba1e4f97d35e407040a4

And while I was at it, I changed also some other bits like:
https://github.com/emanuele45/Dialogo/commit/614b2fec60b22b3be745c8b3d2a044cd4e37c587
and:
https://github.com/emanuele45/Dialogo/commit/d814865bb37cfec079bc4f19baae0cef2e029ba5

If there is something that doesn't work let me know. ;)

Maybe @TE :P
Bugs creator.
Features destroyer.
Template killer.


Re: "new" icon and long subjects

Reply #3
Don't drink too much!! :P

Don't worry, there is no rush, I just drop my questions around and from time to time I test the @, for example now I can do an @Spuds just for fun. :P
Bugs creator.
Features destroyer.
Template killer.

Re: "new" icon and long subjects

Reply #4
And it worked :D

Plan to update the site this PM so we can play with the latest ... trying to determine what to do about the BB issue with quick edit as I would like to have that fixed (and have a couple of choices, just deciding which to do)
Squish squish. squish, squish, squish.
Find a bug,
Make a wish.

Re: "new" icon and long subjects

Reply #5
I think this has been merged...well, moving out anyway. :P
Bugs creator.
Features destroyer.
Template killer.