Skip to main content
Topic: IRC (Read 110396 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

Re: IRC

Reply #135

Yeah but there's an option to turn off parsing of php files. Admittedly most n00bz wouldn't have that turned off, but since it's some (not sure how much) more code to run I run the site with it disabled. I suppose as long as it's on by default it'll be pretty safe for most, but the presentation in the editor is not really conducive to tracking errors anyway. There's no syntax highlighting, and formatting gets lost, and the template gets split into segments, so the whole thing is generally a bit of a schemozzle. Even with CSS files, it's really a lot easier to just download the flipping thing and edit in on your desktop.

ETA: Just had an idea. Might work, might not. How about if there was a built-in thingy to download and upload selected files? Sort of like attachment handling but for core files. Could replace the editor.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: IRC

Reply #136

QuoteJust had an idea. Might work, might not. How about if there was a built-in thingy to download and upload selected files? Sort of like attachment handling but for core files. Could replace the editor.

I got one of those, it's called FileZilla ;)

Re: IRC

Reply #137

Yeah I know, but it's not a built-in thingy. N00bz like built-in thingys.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: IRC

Reply #138

There are some things that shouldn't really be built in thingies. They cause a lot of trouble.

Re: IRC

Reply #139

Quote from: Antechinus – Yeah but there's an option to turn off parsing of php files. Admittedly most n00bz wouldn't have that turned off
No, there isn't any option to turn off the check. I think you're thinking at the "standard" template eval.

The check I'm talking about prevents you from saving the template you're editing at all, in the admin panel, if it has syntax errors. So you just don't get a broken template. (well, not as broken as syntax errors, the rest is free game).
At least, that's how it was supposed to work. I fixed several issues with it and around it, and it's still not ok.

Quote from: Arantor – There are some things that shouldn't really be built in thingies. They cause a lot of trouble.
Yes, and a full FTP client is a different software. :) Really I think our time is better used to continue to make Elk, not to make Elk into a FTP client. I appreciate sharing your stance, Arantor, afaik you have done more than anyone on precisely this and around it.
But anyway, if anyone is willing to have such a gadget, they can make a FTP client in PHP, and embed in it Elk-specific knowledge (directories, what means each, read the theme info, the subdirectories, help, etc). Some base of working with the filesystem and a FTP client implementation exists.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #140

(05:29:49 PM) elkarte_git entered the room.
(05:29:49 PM) elkarte_git: [elkarte] none pushed 10 new commits to master: http://git.io/GnLTuQ
(05:29:49 PM) elkarte_git: elkarte/master 46d6a1b Spuds: ! More things that html5 would not like, mostly width/height on images for this batch...
(05:29:49 PM) elkarte_git: elkarte/master edd68c5 Spuds: ! similar html5 prep updates to install and upgrad...
(05:29:49 PM) elkarte_git: elkarte/master ad9a485 Spuds: ! missed the attribute...
(05:29:49 PM) elkarte_git left the room.
(05:30:53 PM) Norv: Testing github bot.

(11:56:00 PM) ***emanuele haz discovered oembed! :D

(02:22:14 AM) ElkArte_Gitbot: [Elkarte] Spuds opened pull request #276: Various fixes for several niggly things ... descriptive eh? (master...bumpsalongtheway)  http://git.io/quvT2A

(02:22:58 AM) Spuds: Well that notifcation was pretty much real time ....

(12:01:39 PM) ElkArte_Gitbot: [Elkarte] emanuele45 opened pull request #278: Fix for #277 (master...master)  http://git.io/8d39yg
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #141

(03:08:58 PM) ElkArte_Gitbot: [Elkarte] norv pushed 2 new commits to master: http://git.io/IRsMrQ
(03:08:58 PM) ElkArte_Gitbot: Elkarte/master 19b6e4a emanuele: Remove of ban triggers works again... Fixes #277...
(03:08:58 PM) ElkArte_Gitbot: Elkarte/master ab8dc8d Norv: Merge pull request #278 from emanuele45/master...


(03:19:08 PM) ElkArte_Gitbot: [Elkarte] norv pushed 9 new commits to master: http://git.io/rZwV8w
(03:19:08 PM) ElkArte_Gitbot: Elkarte/master 1f15a73 Spuds: ! make sure the default avatar is served from avatars (with one / as well)...
(03:19:08 PM) ElkArte_Gitbot: Elkarte/master 2ffd03a Spuds: ! zero is a valid post group, use isset not empty for check...


(03:24:03 PM) ElkArte_Gitbot: [Elkarte] norv pushed 8 new commits to master: http://git.io/7MRDSw
(03:24:03 PM) ElkArte_Gitbot: Elkarte/master b2fe224 emanuele: When  splitting a topic is possible to move the new topic to a different board, plus it is possible to leave a message where the posts have been moved...
(03:24:03 PM) ElkArte_Gitbot: Elkarte/master 29b0557 emanuele: A small parameter to decide the behaviour of the "current board" in the dropdown: disabled or selected...
(03:24:03 PM) ElkArte_Gitbot: Elkarte/master 947146d emanuele: These are followups or whatever they would be called...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #142

The git commits notifications are better off in their own space, aren't they? I hope it's okay on the channel, but better logged separately on the site.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #143

(02:52:19 AM) Norv: seeing the spammers, I wonder if BB is working
(02:55:55 AM) Norv: Ah. It does.
(03:10:19 AM) Spuds: Yeah BB is doing what it can .... I changed the reg question to see if that helps ... removed SMF from the question, maybe you can come up with a better one.
(03:35:21 AM) Spuds: I also have not enabled the honey pot check option, so may do that to see what extra protection it provides
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #144

(10:31:16 PM) emanuele: Do you plan to have multiple themes at elk.net?
(10:46:02 PM) emanuele left the room (quit: Remote host closed the connection).
(11:04:25 PM) Norv: Ah well, sorry, I wasn't paying attention to the channel. Yes of course, would have been the answer. I'd like to make the site into more of a staging/testing place, for themes as well as core code and others.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #145

(11:11:45 AM) elk_core: [Elkarte] norv opened pull request #280: Admin controllers (master...admin)  http://git.io/1lB4oA

(05:41:12 PM) Spuds: I enabled the http:bl function of BB so we can see how it deals with them spammers ... tirggerd 45 times or so last night.

(11:26:40 PM) emanuele: Norv, does it make sense? https://github.com/emanuele45/Dialogo/commit/80ed0e7ccb6bef1a13c26823c3fa8b8d1b904df0
(04:43:01 PM) Norv: emanuele: that looks fine
(04:46:41 PM) emanuele: Cool! :D
(04:50:35 PM) emanuele: I was adding few minutes ago a couple of functions: addBefore and addAfter
(04:50:37 PM) emanuele: that could be useful I think
(04:51:12 PM) emanuele: I don't like 100% the result, I'll see again after a bottle of wine. :P

(09:03:43 AM) Norv: Good morning.
(09:12:34 AM) ***Norv is amazed I still remember what I did last night and why. TimeVortex: opinions so far, on admin controllers and "settings forms": https://github.com/norv/elkarte/blob/admin/sources/admin/ManageServer.php#L113
(11:49:52 AM) TimeVortex: Don't have much time, but on first glance it looks like an OO-ified version of the ManageServer.php of old, which is a good thing. Part of me would love to see the Class-Form.php used, though. Perhaps you're already using it in a different file/level?
(12:29:25 PM) Norv: Not yet. I didn't use it yet because the refactoring to it is not working too directly (or I didn't manage to do it nicely). Perhaps with this branch (OOP versions of controllers and a "Settings_Form" which is basically very silly - but separated), I can look into using it for admin forms.

(03:58:28 PM) elk_core: [Elkarte] norv pushed 78 new commits to master: http://git.io/kfyD9w
(03:58:28 PM) elk_core: Elkarte/master 2dcf6ec Norv: Add controller class to the menu, as another index in the menu array....
(03:58:28 PM) elk_core: Elkarte/master 92cf31a Norv: Move viewadminfile action to ViewQuery....
(03:58:28 PM) elk_core: Elkarte/master 93c445b Norv: Rename the admin debugging file as AdminDebug.php....
Last Edit: March 31, 2013, 07:32:02 pm by TestMonkey
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #146

(07:03:26 PM) elk_core: [Elkarte] norv opened pull request #281: Admin controllers, updates (master...admin)  http://git.io/O4YHKw
(07:10:12 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/VxRbOA
(07:10:12 PM) elk_core: Elkarte/master 582ba4a Norv: Security settings administration: rework the settings pages as 'settings forms'....
(07:10:12 PM) elk_core: Elkarte/master 5eb781f Norv: Fix core features bug. Rename the last admin area to what it currently is: features and options screens....
(07:10:12 PM) elk_core: Elkarte/master 094ffa2 Norv: Rework Features and Options pages, to use 'settings forms' and for naming patterns....

(07:04:51 PM) Norv: emanuele: the "new look" of admin area is in. /hides
(07:21:53 PM) ***emanuele goes run git pull elk master

(10:28:22 PM) ***emanuele was thinking to add sort of layers to createList too... O:-)
(10:33:11 PM) emanuele: I found again what I was playing with to extend the post area and other things, it was hidden in a branch! :D
(10:33:31 PM) emanuele: problem is I don't like it so much...
(10:40:38 PM) emanuele: I mean I don't like what I came up with, because I started make things very complex, but yet not enough flexible as I would like
(10:49:43 PM) Norv: whitish theme
(10:49:48 PM) Norv: :)
(10:50:02 PM) Norv: ah, good to hear
(10:50:17 PM) Norv: (you scared me with that loss issue :( )
(10:50:27 PM) emanuele: me too... lol
(10:55:24 PM) Norv: layers to List? No idea. /me think I should make List and Menu classes too.
(10:59:21 PM) emanuele: everything sort of started when I was plying with messageindex to make it use createList
(11:01:04 PM) emanuele: in that branch I separated the "main" part of template_show_list (the one that actually creates the list) from the part above and below (where there are the pages, and alike)
(11:02:30 PM) emanuele: this because the main body of my messageindex was rather different from the usual template_show_list (or whatever it is, I don't remember), but the rest was nice to have in place anyway without having to rewrite it
(11:03:41 PM) emanuele: so, from that to layers the step is very small
(11:43:03 PM) Norv: :)
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #147

(11:49:08 PM) elk_core: [Elkarte] Spuds opened pull request #282: ! Typo, should be DELETE (master...bumpsalongtheway)  http://git.io/EemT1Q

(11:49:23 PM) elk_core: [Elkarte] Spuds opened pull request #283: ! Update the old editor to 1.4.2, other changes to support were done already... (master...editor)  http://git.io/jekqig

(11:58:12 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/hKaOsA
(11:58:12 PM) elk_core: Elkarte/master 0597d73 Spuds: ! Update the old editor to 1.4.2, other changes to support were done already...
(11:58:12 PM) elk_core: Elkarte/master 9db9e5c Norv: Merge pull request #283 from Spuds/editor...

(12:01:38 AM) Norv: wow Spuds is on a roll with html5

(12:06:28 AM) elk_core: [Elkarte] norv pushed 7 new commits to master: http://git.io/du8CDA
(12:06:28 AM) elk_core: Elkarte/master ea493ee Spuds: ! remove type="text/javascript" and  type="text/css" from the default theme template files only...
(12:06:28 AM) elk_core: Elkarte/master 7e4fe10 Spuds: ! align=center to class=centertext for bbc and html5...
(12:06:28 AM) elk_core: Elkarte/master 4433186 Spuds: ! move border=0 to css for html5...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #148

(12:22:23 AM) emanuele: Norv: https://github.com/emanuele45/Dialogo/commits/extend_post
(12:22:59 AM) emanuele: though, probably it would look nicer in a class like for template layers or similar?
(12:42:48 AM) Norv: Oh. Cool!
(12:43:09 AM) Norv: (sorry for the afk emanuele)
(12:43:48 AM) emanuele: don't worry, I found another template I could kill... O:-)
(12:44:03 AM) Norv: Likes.
(12:44:26 AM) Norv: if you're in the mood for a class for them layers or something, have fun
(12:44:49 AM) Norv: You're still in the business of killing templates, huh?
(12:45:01 AM) Norv: I should give you much more to kill...
(12:45:26 AM) Norv: As a gift, of course. O:-)
(12:46:17 AM) emanuele: well, it's a duplicate in that branch
(12:46:54 AM) Norv: Excuses!
(12:46:56 AM) emanuele: because I split the "make event" piece from the post page and now the two functions (the one in post and the one in calendar are almost the same, so....

(01:06:12 AM) elk_core: [Elkarte] norv opened pull request #285: Admin templates (master...admin_templates)  http://git.io/1BC_4Q

(01:29:21 AM) Norv: Is this way better or worse?
(01:29:23 AM) Norv: https://github.com/elkarte/Elkarte/pull/285
(01:38:11 AM) emanuele: core features seems a bit overkill alone in the file, though it's not a big issue
(01:52:04 AM) Norv: yes, well
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #149

(03:28:24 AM) elk_core: [Elkarte] Spuds pushed 3 new commits to master: http://git.io/VWvBxQ
(03:28:24 AM) elk_core: Elkarte/master 6d3a3d3 Norv: Split templates in admin area in their own files....
(03:28:24 AM) elk_core: Elkarte/master 012728f Norv: Admin template update...
(03:28:25 AM) elk_core: Elkarte/master b079fec Spuds: Merge pull request #285 from norv/admin_templates...

(03:53:34 AM) elk_core: [Elkarte] norv opened pull request #286: Playing with errors. (master...errors)  http://git.io/w2DeIA
The best moment for testing your PR is right after you merge it. Can't miss with that one.