Skip to main content ↑ ↓
Which file should contain the string "insert"? Started by forumovod · · Read 23321 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

Which file should contain the string "insert"?

Which file should contain the string "insert"? I can't find it for translation.
screen.jpg

Re: Which file should contain the string "insert"?

Reply #1 –

I think it's Line 50 of Editor.english.php:

Code: [Select]
$editortxt['Insert'] = 'Insert';
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Which file should contain the string "insert"?

Reply #2 –

Not that, I have that line translated and I still see the english text.

edit
it's hardcoded into /themes/default/Post.template.php at line 453
Code: [Select]
						<input type="button" class="button" value="insert">

I move this topic to Bug Reports
sorry for my bad english

Re: Which file should contain the string "insert"?

Reply #5 –

Quote from: emanuele – ARG!
Dang.

https://github.com/elkarte/Elkarte/commit/029ca2c267ebf3806253da74e816c44400a8f5ee

The code is the difference between insert and Insert. Is this correct? Or another language file?
Post.template.php
Code: [Select]
<input type="button" class="button" value="' . $txt['insert'] . '">
Editor.english.php
Code: [Select]
$editortxt['Insert'] = 'Insert';
Last Edit: September 16, 2020, 05:20:57 pm by forumovod

Re: Which file should contain the string "insert"?

Reply #6 –

The commit on GitHub shows the string going in themes/default/languages/english/Post.english.php ;)

Although it does seem a bit silly to have exactly the same string called in two separate files. I can see that confusing someone sooner or later. I would think Editor.******.php should be able to handle it. Better grumble at Ema.

Or you could just try it your way. If it works, that's even better.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Which file should contain the string "insert"?

Reply #7 –

Quote from: forumovod –
Quote from: emanuele – ARG!
Dang.

https://github.com/elkarte/Elkarte/commit/029ca2c267ebf3806253da74e816c44400a8f5ee

The code is the difference between insert and Insert. Is this correct? Or another language file?
Yes.
Green: add
Pink: remove

Quote from: forumovod – Post.template.php
Code: [Select]
<input type="button" class="button" value="' . $txt['insert'] . '">
Editor.english.php
Code: [Select]
$editortxt['Insert'] = 'Insert';
It's not Editor.english.php, it's Post.english.php and it's not $editortxt, but $txt. ;)
You see the file names at the beginning of each code block.
Bugs creator.
Features destroyer.
Template killer.

Re: Which file should contain the string "insert"?

Reply #8 –

Quote from: emanuele – It's not Editor.english.php, it's Post.english.php and it's not $editortxt, but $txt. ;)
You see the file names at the beginning of each code block.

This is understandable. But logically it should be in Editor.english.php, not in Post.english.php.

Re: Which file should contain the string "insert"?

Reply #9 –

Well, I'm pretty sure it has to be in Post.english.php, but if you know the logic behind the files in Elk, more than I do, then be my guest.
Bugs creator.
Features destroyer.
Template killer.

Re: Which file should contain the string "insert"?

Reply #10 –

Hi,
I'm with the 1.1.7 patch since some weeks to test it and this problem is still here : is it possible to include the solution in the patch ?

Re: Which file should contain the string "insert"?

Reply #11 –

It should be in there .... Are you saying to translated txt['insert'] in the Post.english.php file and its not changing? 

Unfortunerly I know there are a few duplicate stings in different language files which complicates things, but the system only loads the language files that are required (requested) at the time, not all are available all the time.

Re: Which file should contain the string "insert"?

Reply #12 –

Hi @Spuds ,
i'm saying there is no channel txt['insert'] in the Post.english.php
no code <input type="button" class="button" value="' . $txt['insert'] . '"> in post.template.php.
There are the channels $editortxt['Insert'] = 'Insert'; in Editor.english.php and $editortxt['Insert'] = 'Insérer'; in Editor.french.php but it's not the same 'Insert'.

Re: Which file should contain the string "insert"?

Reply #13 –

Quote from: augras – no code <input type="button" class="button" value="' . $txt['insert'] . '"> in post.template.php.
that is strange, I have a test forum 1.1.6 + 1.1.7 patch and I see that in Post.template.php

do you have:
Code: [Select]
						<input type="button" class="button" value="insert">
?

In my Post.italian.php there is no
$txt['insert'] = 'Insert;
but after adding manually I see the "Insert" word translated correctly.
sorry for my bad english

Re: Which file should contain the string "insert"?

Reply #14 –

Quote from: radu81 –
Quote from: augras – no code <input type="button" class="button" value="' . $txt['insert'] . '"> in post.template.php.
that is strange, I have a test forum 1.1.6 + 1.1.7 patch and I see that in Post.template.php

do you have:
Code: [Select]
						<input type="button" class="button" value="insert">
?
Hi,
I have the same thing on my old forum and on a new fresh one i made to test.
I have no more this line :
Code: [Select]
						<input type="button" class="button" value="insert">

If i insert manually $txt['Insert'] = 'Insérer'; in my Post.french.php i get an error when i want to edit a post

elkarte_french-insert.png