Skip to main content
Topic: IRC (Read 107516 times) previous topic - next topic
0 Members and 2 Guests are viewing this topic.

Re: IRC

Reply #75

Quote from: TestMonkey – (10:30:17 PM) Norv: emanuele: opinions? https://github.com/elkarte/Elkarte/pull/152
(10:39:58 PM) emanuele: No strong opinions, the avatar is a bit boring, that's all
(10:50:52 PM) Norv: Hmm... we could pick another, from a set of avatars... what was that one you folks chose
(11:12:43 PM) emanuele: It can be changed at any time, it doesn't break anything. :P
Default avatars! :D

Re: IRC

Reply #76

(02:30:50 PM) Trekkie101: I miss timestamps on posts :(
(02:34:12 PM) Trekkie101: OH they exist as a hover message
(02:34:17 PM) Trekkie101: But not on iPad
(02:53:13 PM) TimeVortex: Yeah, I miss them too.
(02:53:37 PM) TimeVortex: I like how the 'last edited' timestamps appear the top, though.
(02:53:54 PM) TimeVortex: Would like to see the regular timestamps in that spot, too.
(02:57:20 PM) Trekkie101: Seems odd not having them, even a shrunken version to reduce clutter
(02:57:38 PM) Trekkie101: 24/2/13 @ 12:57pm
(02:58:48 PM) TimeVortex: "Two days ago at 12:57pm"
(02:58:51 PM) TimeVortex: "Seven hours ago"
(02:59:06 PM) TimeVortex: Having a full date('r') on hover
(02:59:44 PM) Trekkie101: Something though :P
(02:59:57 PM) Trekkie101: I may go try and commit it back in somehow :P

(07:15:31 PM) emanuele: YAY!
(07:15:56 PM) emanuele: It's a bit of a PITA create users from an external application into SMF/Elk using the "correct" functions...

(08:15:52 PM) Trekkie101 entered the room.
(08:49:46 PM) Norv: a Trekkie101! runs with some stolen artefact of sorts :P
(09:15:32 PM) Trekkie101: lol?
(09:15:36 PM) Trekkie101: Bring it back!
(09:28:14 PM) ***Norv has ran away and doesn't hear :P

(09:38:09 PM) emanuele: http://www.simplemachines.org/community/index.php?topic=498122.msg3497137#msg3497137
(09:38:29 PM) emanuele: users created/deleted in Joomla are copied over at SMF
(09:38:59 PM) emanuele: now the other: users created/registered in SMF moved to joomla.
(09:39:19 PM) emanuele: and finally everything to Elkarte! :P
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #77

(10:27:10 PM) Trekkie101: anyway im heading out then early bed for early work tomorrow, updated some of the wiki earlier
(10:27:20 PM) Norv: great, thanks
(10:27:31 PM) Trekkie101: :) see the about page

(09:40:42 PM) emanuele: BTW: can we get rid of any isAllowedTo, allowedTo, fatal_lang_error and fatal_error in subs? :P
(09:41:14 PM) emanuele: or at least give a way to override them without having to rely on tricks like set $user_info['is_admin']
(09:41:30 PM) emanuele: (or are these tricks valid?)
(09:47:57 PM) Norv: emanuele: I thought they're essential functions, and I don't know the problem with tricks?
(10:26:15 PM) Norv: emanuele: for an old and slow brainz (i.e. mine) could you point out some code with the problem/trick?
(10:31:12 PM) emanuele: https://github.com/emanuele45/joomla_bridge/blob/master/smf2.php#L42
(10:34:42 PM) emanuele: the problem there is that the groups are not in-synch
(10:35:07 PM) emanuele: I'm not completely sure if this is good TBH
(10:35:18 PM) emanuele: though it's where I am at the moment
(10:36:01 PM) emanuele: (and I'm not even sure the joomla user is logged in into SMF, that's why I don't loadUserSettings etc.
(10:47:41 PM) Norv: Ahh... I remember, err. No, I don't remember - have you seen how the mediawiki bridge plays around with the issues on SMF auth?
(10:47:59 PM) emanuele: lol
(10:48:20 PM) emanuele: I think it doesn't...
(10:48:49 PM) emanuele: WM simply takes the user from the SMF db and brings it to MW
(10:49:09 PM) emanuele: sort of what I did with the joomla auth plugin (not yet at github)
(10:51:32 PM) Norv: Okay... As a general idea, I think you're on a great track here, and we should simplify auth, integrations/bridges are your great way to find what you need it to do
(10:51:49 PM) Norv: but I'm not sure about how you set over there, $user_info admin...
(10:52:14 PM) Norv: that doesn't seem right at all. Why exactly is it necessary, what doesn't work?
(10:52:54 PM) emanuele: isAllowedTo in deleteMembers
(10:53:50 PM) emanuele: https://github.com/emanuele45/Dialogo/blob/master/sources/subs/Members.subs.php#L60
(10:53:55 PM) Norv: Oh. So you need a .subs function which doesn't do permission checks.
(10:55:10 PM) Norv: This is true (but I didn't always see how to rewrite some of the existing functions): we should have .subs functions without permission checks or at most some parameter to set, to say "buzz off, don't"
(10:54:23 PM) emanuele: or a way to overrided permission checks
(10:54:53 PM) emanuele: allowedTo would be fine
(10:55:15 PM) emanuele: because it returns true/false but doesn't try to log you in
(10:55:45 PM) emanuele: no, I'm stupid, there problem is always there.. lol

(10:56:38 PM) Norv: deleteMembers() has $check_not_admin, can't you use it?
(10:56:58 PM) emanuele: that is used to check if the user you are deleting is an admin or not
(10:57:26 PM) Norv: ah, spoke too soon. I thought it was that... okay.
(10:57:42 PM) emanuele: me too... lol
(10:58:00 PM) emanuele: (I mean I thought it was that, but when I used it I discoverd it was something else)

(10:58:41 PM) Norv: the way would be, to write .subs utility functions, more granular maybe, which do the job without asking who'z you.
(10:59:03 PM) Norv: and separate them carefully by name (and/or params) from the others, those with checks

(10:59:41 PM) Norv: IMO. I don't see how we can otherwise overwrite isAllowedTo()... well I do see, but I'm not sure it isn't too odd
(10:59:56 PM) emanuele: lol
(11:06:56 PM) Norv: Well in theory, if you really want, we can play games with OOP: have a Permissions class for isAllowed() and friends, and a subclass of it, for use in such cases (and which doesn't do the job). But the switch back and forth (the 'real' permissions checks and the 'fake' ones) doesn't smell right, nor safe... Or a similar trick, a variable to set, to know that isAllowed() will bypass the 'real' check. But again, trickish. I feel I'm listing them only to see how bad they smell... IMO.

(11:08:46 PM) Norv: If I see this right (looking quickly at the code), the isAllowed() calls in deleteMembers() are only at the beginning of the function. So we can rewrite this quickly
(11:11:09 PM) emanuele: the funny thing is that in registerMember I just had to use an "interface" SMF doesn't know to skip the checks
(11:11:41 PM) emanuele: the only thing left is just the IP registration that is taken from $user_info if the interface is not admin
(11:14:50 PM) Norv: we should be able to put at your disposal simple utility functions, which do exactly the main operations on user auth/manage: register, delete, login this guy and log him out, stuff. As backend functions (=without permissions checks)
(11:16:45 PM) Norv: At most, with a param (when it's a bit too much to refactor otherwise for now)

(11:46:14 PM) Norv: thanks for grumbling about deleteMembers() emanuele. There's a serious issue here...[...]
(11:55:53 PM) ***Norv broke deleteMembers() happily, and will submit a PR :)
Last Edit: February 24, 2013, 09:56:28 pm by TestMonkey
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #78

(11:52:54 PM) ***emanuele is changing Elkarte's color scheme for his own forum O:-)
(11:59:12 PM) Norv: Elk forum wants an experimental color scheme too, selfish.
(02/25/2013 12:31:10 AM) TimeVortex: I suggest mauve.
(12:34:14 AM) ***emanuele needs a lot of yellow...
(12:44:47 AM) Norv: Mauve?? shoots TimeVortex with fire
(12:44:57 AM) TimeVortex: >:)

(12:45:30 AM) TimeVortex: On a serious note, I liked the grey site theme that SimpleMachines.org sported in the very beginning.
(12:45:40 AM) TimeVortex: I probably have it somewhere, still.
(12:45:55 AM) TimeVortex: Looks a bit daft these days though, probably. ;)
(12:45:58 AM) Norv: Ahh I remember something...
(12:46:35 AM) Norv: There was something very easy and pleasant about it. I don't think I have it though, just for fun even.
(12:46:49 AM) TimeVortex: http://web.archive.org/web/20050929112304/http://www.simplemachines.org/community/index.php hnnng not quite there

(01:12:11 AM) emanuele: do you have any plan for the useless seo thing?
(01:13:37 AM) Norv: If you're asking me (which you shouldn't), nope. Trekkie, who's been hiding, maybe.

[...]
(01:19:24 AM) ***Norv bumps ema on the head. Take that! :D
(01:25:47 AM) ***emanuele takes the beer out of Norv's hand. Enough for today.
(01:30:33 AM) Norv: Pfft. Mean.

(01:40:37 AM) Norv: Say, what if Elk would look kinda like this: http://gnome-look.org/content/show.php/Milke?content=23687
(01:41:49 AM) ***Norv hopes you won't all do what Ema just did. MY beer!
(01:42:29 AM) emanuele: gnome is ugly... :P
(01:44:13 AM) Norv: Can't argue with that

(01:44:00 AM) emanuele: Spuds! use_click_menu O:-)
(02:26:00 AM) Spuds: You tested what is on the site or is this some other menu?
Last Edit: February 24, 2013, 09:26:57 pm by TestMonkey
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #79

(03:00:16 AM) Trekkie101: bug on install
(03:04:54 AM) Trekkie101: SUBSDIR is never initialised
(03:55:07 AM) Trekkie101: Sent a pull request
(03:55:18 AM) Trekkie101: But it looks like its being removed purposefully?
(03:55:22 AM) Trekkie101: extdir instead?
(03:57:17 AM) Norv: Both: SUBSDIR is for our subs files, and EXTDIR for the external libraries we include
(03:58:22 AM) Norv: Thanks for the PR! I'm pulling it locally to see, I wonder if perhaps it should be initialized sooner (not sure)
(03:58:57 AM) Trekkie101: Ill commit the Settings.php one too then
(04:02:04 AM) Trekkie101: Those were the two that gave me trouble
(04:02:23 AM) Norv: It looks like you're right: it's a good place in install (well it could be sooner but doesn't seem relevant)
(04:03:43 AM) Trekkie101: Nothing seems to call it before then anyway.
(04:04:06 AM) Trekkie101: In Settings.php, its possibly in the wrong place, should prob be above languages
(04:04:11 AM) Norv: Trekkie101: I think you were right the first time, sorry about that! My fault.
(04:04:18 AM) Norv: Yes
(04:06:21 AM) Norv: We didn't want too many in Settings.php, to keep it to the minimum (only the strictly necessary). Because you don't want (I assume) to change SUBSDIR on your installation, and only those you will want to change, or it makes sense to change for your installation, are in Settings
(04:07:29 AM) Trekkie101: Makes sense then :)
(04:10:49 AM) Norv: So, install will have to deal with it, like you did initially. Sorry for the hesitation I had (I'm not yet familiar myself with what we did lol!)
(04:11:16 AM) Trekkie101: Thats ok :P both PR's are there, just smack back the settings one and keep the install
(04:13:54 AM) Trekkie101: This time im really off to bed!
(04:15:47 AM) Norv: Nighty! :D And thanks!
(04:17:20 AM) Trekkie101: welcome :) it was stopping my install
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #80

(11:31:52 PM) emanuele: http://img10.imageshack.us/img10/514/screen91b.png
(11:32:02 PM) ***emanuele should not do this kind of things... lol
(11:33:10 PM) Norv: oh hah nice site :D
(11:34:09 PM) emanuele: just removing everything... O:-)
(11:34:50 PM) emanuele: it's a bit too bright probably
(11:35:04 PM) Norv: some greyish and fadeouts would do so nicely
(11:35:22 PM) ***Norv shares opinions on design. Time to run.
(11:36:30 PM) emanuele: at the moment the base is #fefefe, I'll try something a bit more grey

(11:39:31 PM) ***Norv says something about the review of error classes going so slowly. So tired, trying to keep attention up (where's the coffee)
(02/26/2013 12:12:24 AM) Norv: this is great Ema
(12:12:36 AM) Norv: we'll have some fun with them
(12:14:44 AM) emanuele: I'm not sure I fixed CurveClassic...
(12:16:25 AM) emanuele: oh...and I forgot I created a js "something" to handle the errors "live"... lol
(12:16:33 AM) emanuele: I have to remember how it works
(12:26:12 AM) Norv: As you see fit. If the PR addresses the issues noticed however, I think it's ok for this part. (...though admittedly there can be many I missed since I reviewed only live)
(12:34:38 AM) Norv: It might be a good idea to document for developers the error classes and intended js O:-)
(12:37:10 AM) emanuele: yeah...well...I'm changing it right now because it wouldn't work with the editor... O:-)
(12:39:00 AM) emanuele: and also I think it's a bit dumb at the moment because I have to re-declare the class for each "box" I want to check...
(12:39:05 AM) emanuele: not sure it makes sense

(01:22:37 AM) Trekkie101: Where did the site go :?
(01:31:44 AM) Norv: did you say site? what site? :D
(01:32:07 AM) ***Norv thinks that Spuds applies emanuele's fixes on the site...
(01:41:37 AM) emanuele left the room (quit.).
(01:42:38 AM) Norv: :( I didn't mean it...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #81

(03:54:02 PM) Trekkie101: Norv sent you some comments on GitHub, hopefully they'll show up in your notifications
(05:11:58 PM) emanuele entered the room.
(05:41:40 PM) Trekkie101: emanuele I have evidence of Norv making bugz
(05:47:29 PM) emanuele: HIDE IT!!
(05:47:34 PM) emanuele: I have to win! :P
(05:47:42 PM) Trekkie101: I commented on it to point it out :P

(09:03:50 PM) Norv: Trekkie101: thanks for the review! I fixed your issues, is it better now?
(09:04:16 PM) Trekkie101: Yup!
(09:04:36 PM) Norv: :D I am catching up!
(09:04:43 PM) Trekkie101: I've been spending a lot of time trying to learn a fair bit more about the code, an easy way I've found is watch some of the commits
(09:04:59 PM) Trekkie101: Sometimes I see tiny little things :P
(09:05:19 PM) Trekkie101: Also if I see an error/syntax error from a dev build, I try and fix it before calling wolf :P
(09:08:55 PM) Norv: Yup! There's a great thing about code reviews, and more eyes on the code. There's always an extra chance small or big issues will be noticed by a different pair of eyes :)
(09:09:42 PM) Trekkie101: heading home, cya soon!
(09:09:46 PM) Norv: and to be fair, github does a pretty good job with the diff
(09:09:55 PM) Norv: take care! and thanks again! :D
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #82

(07:22:58 PM) Spuds: https://github.com/SimpleMachines/SMF2.1/pull/296
(07:22:58 PM) Spuds: https://github.com/SimpleMachines/SMF2.1/pull/230
(07:22:58 PM) Spuds: Both are around improving membergroup icon stuff ... the first is just a basic pulldown, the second maybe a bit to much ...
(07:22:58 PM) Spuds: Any interest in doing things along those lines for Elk?
(07:26:55 PM) emanuele: the first one looks interesting, I think it would make sense to have
(07:29:13 PM) emanuele: 2nd one...dunno...it would probably be nice to be able to upload several things
(07:31:21 PM) emanuele: I would throw in everything. :P (and MOAR! But maybe that's more for Feature Cat! :P )
(07:31:51 PM) Spuds: That feature cat is crazy !
(07:31:58 PM) Spuds: must be from all the carbs
(07:32:08 PM) emanuele: cats are crazy
(07:32:21 PM) Spuds: :D
(07:33:18 PM) Spuds: I like the upload and presentation view of the second ... not sure about all the drag/drop stuff, tis nice but not sure how may gotchas there may be
(07:37:26 PM) emanuele: autolinking of reply would be nice too...
(07:37:47 PM) emanuele: #5 => link to reply number 5
(07:44:06 PM) Spuds: good idea
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #83

(11:07:45 PM) emanuele: Norv are you around?
(11:08:07 PM) Norv: yes
(11:08:11 PM) Norv: or I claim to :)
(11:09:05 PM) emanuele: https://github.com/emanuele45/Dialogo/blob/master/sources/admin/ManageMembergroups.php#L586
(11:09:12 PM) emanuele: $temp_boards
(11:09:32 PM) emanuele: am I dumb...well I am so it's not really a good question, but let's pretend I'm not
(11:09:40 PM) emanuele: am I dumb or is completely useless?
(11:10:45 PM) emanuele: it's just initialized, assigned, rounded around and ignored completely...
(11:11:31 PM) Norv: Err... yes
(11:11:45 PM) emanuele: ohhh...now I see, it was used just in one other case in search.controller pretending it was useful for themes...
(11:13:14 PM) Norv: and there's a usage in profile too
(11:13:38 PM) emanuele: yep, but for the same reason
(11:13:52 PM) emanuele: and is not used in any template apparently
(11:14:11 PM) Norv: and the code was just copied to managemembergroups
(11:14:17 PM) emanuele: so it should be just another compatibility thing...
(11:14:33 PM) ***emanuele goes drop everything

(11:16:20 PM) Norv: it's board_columns which is supposed to be useful tries to read the code :D
(11:16:48 PM) emanuele: yep
(11:16:58 PM) Norv: alternate board columns...
(11:17:38 PM) Norv: my first reflex would be to take all common code, make a utility function, which can be used to send to the template this info
(11:19:08 PM) emanuele: that's what I was doing O:-)
(11:19:22 PM) emanuele: but I was trying to return the result
(11:19:42 PM) emanuele: and have board_columns too seems a bit useless...
(11:21:38 PM) Norv: the end result is supposed to be board_columns, though, right?
(11:22:07 PM) emanuele: nope
(11:22:21 PM) emanuele: only 'categories' is used
(11:23:15 PM) Norv: the end result of temp_stuff-processing, for the template, I mean
(11:23:42 PM) Norv: (yes, not used in current templates, and supposed to be available for other themes)
(11:23:57 PM) emanuele: ahhh...okay, yes
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #84

(11:25:15 PM) Norv: let me put it this way: do you think it would be worthwhile to: make a file (or more) with helper functions for templates. Which are only extra-processing of the data which is sent anyway to templates. But 'helpers', available so that the template doesn't have to write it itself
(11:25:56 PM) emanuele: eheheh that may look nice, I think
(11:26:30 PM) Norv: this is the case here, for what I can see (and it's by far not the first): apart from the contextual data itself, the core controllers/subs make extra-processing to the data and add to context extra-results, only so that themes don't have to repeat common operations on that data
(11:26:32 PM) emanuele: but I'm probably not the best person to ask... O:-)
(11:30:13 PM) Norv: sounds like 'template helper' functions to me... not sure about the rest (i.e. where to add them, how to "expect" templates to use them... i.e. should we call them or let interested theme call them for extra-context initializations; but you were doing that so O:-))
(11:33:03 PM) emanuele: well...I was not doing the helper thing... :P
(11:34:44 PM) emanuele: https://github.com/emanuele45/Dialogo/commit/ae389acf2ca261d16be877670e110000b0ec2e78
(11:33:57 PM) Norv: what would you expect: if you theme, and you remember that documentation of Elk told you that you can haz boards sorted in alternate columns (or something). Would you find it 'natural' to call a function which returns you those boards columns in arrays; or, call a function which adds to $context for you some ['board_columns']; or, expect there are 'board_columns' already processed even if you weren't using them
(11:36:08 PM) emanuele: well, that depends on the documentation
(11:36:20 PM) emanuele: and how it is written. :P
(11:36:25 PM) Norv: haha
(11:36:39 PM) Norv: I thought the documentation depends on the code to document :D
(11:37:44 PM) emanuele: unless it's outdated or badly written ;D
(11:37:54 PM) emanuele: lol
(11:39:42 PM) Norv: yup. There's very little developer/designer documentation for this codebase. OK, well, I think personally I prefer the first two (no extra processing until you want and call it in some way). I wonder if that means it would be better to have such helpers in... well not in theme... but in some place
(11:40:19 PM) emanuele: LOL
(11:40:32 PM) Norv: O:-)
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #85

(11:41:48 PM) emanuele: Is it okay Board.subs.php for that function?
(11:42:08 PM) Norv: well........ not really...
(11:42:14 PM) emanuele: lol
(11:42:35 PM) emanuele: wait you mean the helper or the function I put there now?
(11:43:39 PM) Norv: I mean the helper. It's not backend, it's one of those cases which go beyond even your prepareXxxContext() stuff - very close to prepare but even more tied to the view than that...
(11:43:59 PM) Norv: Your function is fine!

(11:44:26 PM) Norv: (except that it uses $context O:-))
(11:46:28 PM) Norv: Correction: it didn't intend to use context sorry! I just glanced at a use, that's all (https://github.com/emanuele45/Dialogo/commit/ae389acf2ca261d16be877670e110000b0ec2e78#L3R1080)
(11:55:36 PM) emanuele: it's broken anyway...
(11:55:38 PM) emanuele: lol
(11:55:44 PM) emanuele: I'm fixing it now
(02/28/2013 12:00:11 AM) Norv: thanks for that! hey please note that you is currently on your master branch. You know you'll hate me when I might cherry pick, and you end up with a needless messy merge. O:-)
(12:04:28 AM) emanuele: I know, I was about to branch for another thing, but got caught by all these repetitions... O:-)
(12:04:42 AM) emanuele: now should work a bit better
(12:05:42 AM) Norv: just to be clear: I think you're right that function doesn't need board_columns stuff. Only categories. We're just talking two different things here. :) The allboards() is great, and will have a very nice readability/code design result. If and what we can do with the extra-board columns stuff, is another thing
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #86

(12:16:21 AM) emanuele: action_ignoreboards now is very nice! :D
(12:19:01 AM) TimeVortex: http://www.elkarte.net/index.php?action=profile;area=ignoreboards
(12:19:04 AM) TimeVortex: Unable to load the 'action_ignoreboards' template.
(12:19:07 AM) ***TimeVortex smirks
(12:19:16 AM) TimeVortex: I suppose I should test locally.
(12:23:59 AM) Norv: Err... I must have missed a subtemplate loading
(12:27:05 AM) emanuele: fixed the template and another bug too

(12:30:59 AM) TimeVortex: By the by
(12:31:04 AM) TimeVortex: THANKS for adding the dates back in
(12:31:39 AM) TimeVortex: I have some minor issue with it in terms of semantics now, though:
(12:32:02 AM) TimeVortex: Currently (shortened obv.): "<a>Reply #71 - on:[/url] February 23, 2013, 10:47:17 am"
(12:32:04 AM) Norv: thank you emanuele! /me is slow
(12:32:48 AM) TimeVortex: My wish (shortened again): "<a>Reply #71[/url] on February 23, 2013, 10:47:17 am" OR "<a>Reply #71[/url] &emdash; February 23, 2013, 10:47:17 am"
(12:32:57 AM) TimeVortex: &emdash; being —
(12:33:21 AM) TimeVortex: But you lot are probably all using a monospace font, so it will appear less wide than it actually is.
(12:34:15 AM) ***emanuele likes 2nd version
(12:34:24 AM) emanuele: &emdash;
(12:35:07 AM) Norv: Ah I see. Cool, thanks!
(12:35:09 AM) emanuele: just to avoid Ant's rants about "on today/yesterday"  :P
(12:35:15 AM) TimeVortex: The only gripe I have with it, is that you can't read it aloud.
(12:35:22 AM) TimeVortex: Oh, yes, that is actually a great advantage.
(12:35:25 AM) Norv: :D
(12:35:46 AM) TimeVortex: Chances are you'll be getting feature requests for timestamps like "two days ago" and the likes, though. :P
(12:36:06 AM) Norv: pretty sure
(12:38:12 AM) TimeVortex: ;)

(12:38:26 AM) ***TimeVortex kind of misses some sort of build ID in the version number.
(12:38:40 AM) TimeVortex: Now I can't see when the site was last updated. :P
(12:39:32 AM) ***TimeVortex notices he still has 0 posts on Elkarte.net
(12:40:55 AM) emanuele: I think a couple of days ago...
(12:41:10 AM) Norv: ah okay, I will do something like that - build versioning
(12:41:54 AM) Norv: Spuds keeps it very often updated
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #87

(12:12:07 AM) Norv: http://www.elkarte.net/index.php?topic=215 the best solution?
(12:13:50 AM) emanuele: +1 for css I think

(12:25:11 AM) Norv: hey TimeVortex: opinion on tradeoffs here? http://www.elkarte.net/index.php?topic=215
(12:26:12 AM) TimeVortex: Norv: all for the CSS-based solution.
(12:26:45 AM) TimeVortex: At the time it was left like this because of the copy-paste argument; a CSS-based solution won't cripple copy-pasting and will work without JS.
(12:27:04 AM) TimeVortex: (Of course, older browsers will bork on it, but I'm guessing you're not supporting those anyway.)
(12:28:24 AM) ***Norv says something hardly intelligible about how good it is to be around them performance freaks. :)
(12:28:38 AM) Norv: Ah I see. Thanks :D
The best moment for testing your PR is right after you merge it. Can't miss with that one.

 

Re: IRC

Reply #88

(01:12:48 AM) TimeVortex: Norv: heh, looks like my </a>'s were replaced with [/url]'s http://www.elkarte.net/index.php?topic=134.msg1495#msg1495
(01:12:54 AM) TimeVortex: Possibly an editor bug?
(01:13:51 AM) emanuele: nope
(01:13:54 AM) emanuele: that's parse_bbc
(01:14:04 AM) emanuele: (preview without js enabled)
(01:14:51 AM) TimeVortex: A known one, I gather?
(01:16:32 AM) emanuele: mmm...locally works fine
(01:16:45 AM) emanuele: ???
(01:24:13 AM) Norv: it works as <a> in my browser

(01:35:41 AM) Spuds entered the room.
(01:44:58 AM) Norv: A Spuds! Right after I posted som'thing unorthodox about parse_bbc()...
(01:45:09 AM) Norv:  I always knew he was using custom scripts to monitor the site :P
(01:50:00 AM) Spuds: What did I do now :P
(01:50:33 AM) Spuds: Anyone else getting the Sorry, this tree took too long to generate.   On the github site when using the files tab?
(01:51:03 AM) Norv: Yep
(01:51:35 AM) Norv: you broke github. After markdown libs sometime it happened :D
(01:51:48 AM) Spuds: Strange ... also I just updated that menu PR that had ghost conflicts .....
(01:51:56 AM) Spuds: LOL ... maybe that is it !
(01:52:39 AM) Norv: I should write to github if it doesn't get solved. Probably too lazy tonight but I might do so later.
(01:53:41 AM) Spuds: I'm still probably going to re-write a simplier / limited func version of markdownify anyway .... its a bit heavy for what we need ....
Last Edit: February 28, 2013, 12:10:16 am by TestMonkey
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #89

(01:58:03 AM) Norv: On a different note... What if we consider markdown support for 2.0-3.0+, in the editor?
(02:00:41 AM) TimeVortex: Dropping bbc altogether? ;)
(02:03:36 AM) Norv: would that be desirable, TimeVortex? 'Tis a serious question!
(02:08:12 AM) TimeVortex: It would make upgrading a nightmare, methinks.
(02:08:35 AM) TimeVortex: Many people use bbcode with no markdown equivalent
(02:08:52 AM) TimeVortex: (custom bbcode, if nothing else)
(02:12:12 AM) Norv: there isn't much other option than to support those without equivalent... Dunno, I can't imagine just dropping support
(02:14:06 AM) Norv: but on the other hand, I think bbc poses more problems for interoperability, for any federation of content with other applications
(02:14:18 AM) Trekkie101: Over time though, WYSI will replace it though
(02:15:05 AM) Trekkie101: So your backend could really be anything :P
(02:15:47 AM) Norv: front/middleware of sorts, rather :)
(02:32:47 AM) Norv: TBH Trekkie101 I don't think wysiwyg will replace a good ole' lightweight language
The best moment for testing your PR is right after you merge it. Can't miss with that one.