[bug] - moved marked as "new" even after click on them

[bug] - moved marked as "new" even after click on them Started by emanuele · December 17, 2012, 11:32:52 am · Read 10792 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

[bug] - moved marked as "new" even after click on them

December 17, 2012, 11:32:52 am

Sort of regressions: I thought I fixed this quite a long time ago...

Re: [bug] - moved marked as "new" even after click on them

Reply #1 – December 17, 2012, 02:07:01 pm

You probably did.

Re: [bug] - moved marked as "new" even after click on them

Reply #2 – December 17, 2012, 02:36:30 pm

Should be easy to fix again then

Re: [bug] - moved marked as "new" even after click on them

Reply #3 – December 17, 2012, 02:40:33 pm

Quote from: Antechinus – December 17, 2012, 02:07:01 pmYou probably did.

But not hard enough...

emanuele feels it's Spuds fault.

Re: [bug] - moved marked as "new" even after click on them

Reply #4 – December 17, 2012, 02:41:26 pm

I'll take the blame as long as you fix it

Re: [bug] - moved marked as "new" even after click on them

Reply #5 – December 17, 2012, 03:02:21 pm

I have already 17 branches... (and this will be the 18th)

emanuele hates git.

Re: [bug] - moved marked as "new" even after click on them

Reply #6 – December 17, 2012, 03:13:35 pm

I think this should work:

Code: [Select]

	// Is this a moved topic that we are redirecting to?
	if (!empty($topicinfo['id_redirect_topic']))
	{
		markTopicsRead(array($user_info['id'], $topic, $topicinfo['id_last_msg']), $topicinfo['new_from'] !== 0);
		redirectexit('topic=' . $topicinfo['id_redirect_topic'] . '.0');
	}

in Display.php about line 133

Re: [bug] - moved marked as "new" even after click on them

Reply #7 – December 17, 2012, 03:28:06 pm

Quote from: emanuele – December 17, 2012, 03:02:21 pmI have already 17 branches... (and this will be the 18th)
emanuele hates git.

Join the club. Git is a total PITA.

Re: [bug] - moved marked as "new" even after click on them

Reply #8 – December 17, 2012, 04:01:52 pm

Quote from: emanuele – December 17, 2012, 03:02:21 pmI have already 17 branches... (and this will be the 18th)
emanuele hates git.

23... with more than 1/2 with a single theme...

Re: [bug] - moved marked as "new" even after click on them

Reply #9 – December 17, 2012, 04:10:22 pm

Quote from: emanuele – December 17, 2012, 03:02:21 pmI have already 17 branches... (and this will be the 18th)
emanuele hates git.

Hey! It's Smart (tm): look, it didn't even blink, when I committed your fix (couple minutes ago) and then merged your PR with it again.

Smart git is smart.

Re: [bug] - moved marked as "new" even after click on them

Reply #10 – December 17, 2012, 04:29:50 pm

60 in SMF repo... (most of them I don't even know why I create the branch)
I should really delete some of them... LOL