Skip to main content
Topic: IRC (Read 58568 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: IRC

Reply #360
(07/16/2013 01:10:39 AM) elk_core: [Elkarte] emanuele45 opened pull request #681: Send back to the referer? (master...admin_session)  http://git.io/eEMEfA

(05:25:55 PM) elk_core: [Elkarte] eurich opened pull request #683: printpage.template.php (master...restore_printpage)  http://git.io/QXRh3g

(06:09:47 PM) elk_tools: [tools] eurich opened pull request #12: legacy functions from SMF (master...legacy)  http://git.io/KTHhUQ

(08:27:30 PM) elk_core: [Elkarte] Spuds opened pull request #684: Quick Package Fix (master...pkg)  http://git.io/QfCLjg
(09:07:57 PM) elk_core: [Elkarte] eurich closed pull request #684: Quick Package Fix (master...pkg)  http://git.io/QfCLjg
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #361
(09:42:46 PM) elk_core: [Elkarte] eurich opened pull request #685: just a quick fix (master...qfx)  http://git.io/LGhR1g
(02:00:41 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/Cd-RHQ
(02:00:41 AM) elk_core: Elkarte/master 40b39a6 Thorsten Eurich: wrong var was passed.....

(09:49:27 PM) elk_tools: [tools] eurich opened pull request #13: fixes for populate.php (master...populate_fix)  http://git.io/Yi-YaA
(07/17/2013 12:15:03 AM) elk_tools: [tools] norv merged pull request #13: fixes for populate.php (master...populate_fix)  http://git.io/Yi-YaA

(02:03:02 AM) elk_tools: [tools] norv pushed 2 new commits to master: http://git.io/smMG_g
(02:03:02 AM) elk_tools: tools/master fc74be8 Thorsten Eurich: added legacy bbc_to_html functions, formerly used by the old SMF wysiwyg editor.....
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #362
(02:03:34 AM) elk_tools: [tools] norv merged pull request #11: Add install and upgrade scripts for sqlite. (master...sqlite)  http://git.io/YE9sew

(04:21:33 AM) elk_core: [Elkarte] engelnyst opened pull request #686: Errors (master...errors)  http://git.io/x3hGyQ

(08:07:07 AM) elk_core: [Elkarte] eurich merged pull request #683: printpage.template.php (master...restore_printpage)  http://git.io/QXRh3g

(10:03:43 AM) elk_core: [Elkarte] norv opened pull request #687: Actions standardization (admin) (master...actions)  http://git.io/XLvtig
(02:34:19 PM) elk_core: [Elkarte] norv synchronized pull request #687: Actions standardization (admin) (master...actions)  http://git.io/XLvtig
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #363
Too much activity, I won't record it all, skipping more bits.

(02:04:40 PM) elk_core: [Elkarte] norv pushed 1 new commit to master: http://git.io/-SGOvg
(02:04:40 PM) elk_core: Elkarte/master 005fbc1 Norv: Restore (still) missed text strings from previous commits....

(07:15:25 PM) elk_core: Elkarte/master 8fb2f32 emanuele: Moved the PM settings to its own page, and added the possibility to edit the limit of PMs archieved per membergroup from that page. Re-worked also updateMembergroupProperties...
(08:17:09 PM) elk_core: [Elkarte] norv pushed 11 new commits to master: http://git.io/qDpKtg
(08:17:09 PM) elk_core: Elkarte/master f31ed2f emanuele: Used subs for PM controller (the function was there, refined a bit)...
(08:17:09 PM) elk_core: Elkarte/master 02c7c47 emanuele: A function to load membergroups details...I wonder why this function didn't exist yet...did I miss it?...
(08:17:09 PM) elk_core: Elkarte/master 17be51b emanuele: getMemberByName reused in PM controller and removed fatal error from the function...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #364
(07/20/2013 12:32:02 AM) elk_core: [Elkarte] emanuele45 opened pull request #695: Easier and centralised way to handle numbers next to menu items (master...fix_menu)  http://git.io/pzPkdA
(11:18:33 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/Isw6-w
(11:18:33 AM) elk_core: Elkarte/master b7262b7 emanuele: Easier and centralised way to handle numbers next to menu items...
(11:18:33 AM) elk_core: Elkarte/master 6f304c6 emanuele: Some bits of css lost around :P...

(08:02:18 AM) elk_core: [Elkarte] norv pushed 1 new commit to master: http://git.io/70DfdA
(08:02:18 AM) elk_core: Elkarte/master f87acbc Norv: Include the boards subs file....
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #365
(03:23:37 PM) elk_core: [Elkarte] emanuele45 opened pull request #700: Fixed other undefined errors due to missing checks (master...fix_menu_2)  http://git.io/icDCtA
(05:20:23 PM) elk_core: [Elkarte] norv merged pull request #700: Fixed other undefined errors due to missing checks (master...fix_menu_2)  http://git.io/icDCtA

(04:05:16 PM) elk_core: [Elkarte] emanuele45 opened pull request #702: Fixes #615 and adds some classes to the <dd> in the post page (master...post_html5)  http://git.io/TTjiPw

(05:27:03 PM) Norv: > (09:17:32 PM) emanuele: The PR is just closed pending...your rebase Norv?
(05:27:03 PM) Norv: Just to note. I rebased two of them, and committed a couple of fixes directly in master. No biggies, but just to know if you're surprised. All are in.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #366
(05:28:05 PM) Norv: Woah. I just came back after an unexpected few-hours break, and my notifications screen is full. Oops, lol.
(05:39:40 PM) emanuele: LOL

(05:45:24 PM) elk_core: [Elkarte] AaronVanGeffen opened pull request #720: A bit more work on time stamps (master...master)  http://git.io/pDlyrA
(05:46:03 PM) TimeVortex: Hope you don't have too much trouble merging that.
(05:46:21 PM) TimeVortex: Just realised I hadn't pulled from the Elkarte repo before I started.
(05:46:40 PM) TimeVortex: I'm rusty :P

(05:57:18 PM) elk_core: [Elkarte] eurich opened pull request #721: fixes and cleaning (master...bugfix)  http://git.io/worlzA

(06:40:55 PM) Norv: Nah, no worries. It's a very straightforward rebase. PMs were turned upside down in the meantime :D
(06:44:17 PM) Norv: Thanks!

(06:53:56 PM) elk_core: [Elkarte] engelnyst opened pull request #722: Code clean (master...code_clean)  http://git.io/bWtX8w

(06:54:43 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/KworeA
(06:54:43 PM) elk_core: Elkarte/master a525efd Aaron van Geffen: Added missing global to make personal messages work again.
(06:54:43 PM) elk_core: Elkarte/master b97862d Aaron van Geffen: Harmonised timestamps throughout elkarte to use the html5 time tag for both relative and absolute time stamps....
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #367
(06:58:29 PM) Norv: TimeVortex: oh, so you missed the new looks
(06:58:46 PM) Norv: Be kind. It's mostly 1-day old.
(07:02:55 PM) TimeVortex: Ah, yes, I mostly noticed the up/down-buttons just now. Let me merge from upstream...
(07:04:06 PM) Norv: Ahwell, I didn't realize I didn't sign it off when recommitting. TimeVortex: please do consider to sign-off your commits, as acknowledgement of the license under which you make them.
(07:04:24 PM) TimeVortex: Ah shoot, I completely forgot.
(07:04:42 PM) Norv: It's a linux-kernel kind of DCO. To be honest, it's almost meaningless normally. But we come from smf, where I needed it.
(07:04:54 PM) TimeVortex: I'll be sure to do so next time. Regular GPG signature will do, I presume?
(07:05:12 PM) Norv: Only -s tag will do.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #368
(07:06:59 PM) Norv: Please, say you hate the up/down thingies.
(07:07:13 PM) TimeVortex: Yes, I hated them to bits.
(07:07:23 PM) TimeVortex: Looks like they're gone since I merged upstream/master though!
(07:07:36 PM) TimeVortex: Oh, just moved to the right.
(07:08:18 PM) TimeVortex: Much less noticeable though. Certainly an improvement.

(07:08:34 PM) TimeVortex: I do think the "Sort by: Subject / Started by / Last post / Replies / Views / Likes" header on the messageindex is a bit too ... prominent though.
(07:08:55 PM) TimeVortex: Certainly now that they're not column headers anymore.
(07:09:21 PM) TimeVortex: Also double clicking to edit a topic title inline doesn't seem to be working anymore.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #369
(07:09:35 PM) emanuele: What about get rid of the login page too? O:-)
(07:09:49 PM) TimeVortex: Well, you'd still need it for kickGuest()
(07:10:19 PM) TimeVortex: I'm all for hiding the link to ?action=login though
(07:10:48 PM) TimeVortex: "My account" linking to PMs feels a bit weird atm.
(07:11:16 PM) TimeVortex: I suppose that'll relax if those areas (and menus) are merged? Not sure what the plan is.
(07:11:58 PM) TimeVortex: I look forward to seeing what you'll be doing :)
(07:12:53 PM) Norv: What did the login page do to you?
(07:13:28 PM) TimeVortex: It seems a bit superfluous, really. Bit of a relic.
(07:13:28 PM) emanuele: The less the pages the better! :P
(07:13:48 PM) emanuele: I would prefer something like members search is now
(07:13:56 PM) TimeVortex: Much like the "Your message has been posted. You are now redirected to ..." you still see in many forum software packages.
(07:15:06 PM) ***emanuele hates that kind of pages lol
(07:15:18 PM) Norv: I think on the UI, the plan has become to change everything at once: remove all kinds of old markup kept for compatibility and all, add html5 bits (nothing controversial) and in the meantime change the looks according to experience from past and mood for experimentation.
(07:16:16 PM) emanuele: Ohhh... and that reminds me I have to finish the send-topic ajax-like! :D
(07:18:44 PM) Norv: Mmm.. It should be easy for mods/addons to add their auth mechanism..
(07:19:29 PM) Norv: > TimeVortex: Much like the "Your message has been posted. You are now redirected to ..." you still see in many forum software packages.
(07:19:29 PM) Norv: ^^ That was a terrible thing to say lol
(07:19:55 PM) TimeVortex: Is it, really? :P
(07:20:07 PM) TimeVortex: I always despise those intermediate messages.
(07:20:10 PM) Norv: To compare poor ole' login with it!
(07:20:27 PM) TimeVortex: But there's a login form at the top these days!
(07:20:55 PM) TimeVortex: You should not need to see the login page, unless there's a good reason to.
(07:21:05 PM) Norv: Well it redirects you to the full page on error
(07:21:38 PM) TimeVortex: Fair enough, a user shouldn't go there voluntarily.
(07:21:51 PM) TimeVortex: It always gets such a prominent button on the main navigation bar.
(07:24:15 PM) emanuele: Well, if you remove that I would add a dropdown or some overlay to the login, no need to change page just for that...
(07:24:50 PM) Norv: Mmm. Well I'd remove the buttony and link... not the page
(07:25:26 PM) emanuele: lol
(07:25:31 PM) emanuele: yes, okay keep the page :P
(07:27:51 PM) Norv: Just to note, quick login is still an admin option.
(07:28:42 PM) emanuele: Why? :P
(07:28:59 PM) Norv: If there's no button to login page, we'd either remove it as option, or replace it with a button (rofl) when disabled.
(07:29:10 PM) Norv: Because you didn't remove the option! :D
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #370
(08:22:13 PM) elk_core: [Elkarte] Spuds opened pull request #724: Elk is a no rodent software (master...norodents)  http://git.io/zlzBcg

(09:49:43 PM) TimeVortex: Right, fellas
(09:49:52 PM) TimeVortex: There's one thing I don't quite understand
(09:50:13 PM) TimeVortex: Why are controllers/subs both orderer in their own directories *and* suffixed?
(09:50:19 PM) emanuele: lucky you it's just one...
(09:50:44 PM) emanuele: That's Norv fault! :P
(09:50:53 PM) TimeVortex: Is it?
(09:51:07 PM) ***TimeVortex goes to get his pitchfork

(09:53:36 PM) elk_core: [Elkarte] Spuds opened pull request #727: Likes Suggestion (master...lksg)  http://git.io/-aWbPQ

(10:16:44 PM) Norv: do you mean admin, TimeVortex (which is indeed kinda odd and it probably won't have any reasonable followup - except revert), or all /controllers ?
(10:17:36 PM) TimeVortex: Norv: indeed /controllers, /subs
(10:18:03 PM) Norv:  /subs also has .class.php
(10:18:16 PM) TimeVortex: Ah yes, it is mixed.
(10:18:24 PM) TimeVortex: But why the suffixes
(10:19:57 PM) TimeVortex: What's the rationale behind it?
(10:20:51 PM) Norv: We have the three layers: .template, .subs, .controller. To which you can count languages. templates are in /themes, and they are template.php. Subs were also suffixed, and I think keeping it is very easy to recognize.
(10:21:28 PM) Norv: Same goes for controllers. For addons, they'll likely be in the same directory, as long as they don't have many
(10:23:24 PM) Norv: I want them very easy to know where you are, what you are seeing, what you expect to see here. And the class names follow the file names (sort of). You couldn't have duplicates without controller suffix, when we [will] move on to make OOP other classes
(10:27:20 PM) Norv: They're like this: /controllers: Admin_Controller class, Admin.controller.php. Core (/sources): Dispatcher class, Dispatcher.class.php. /subs: Action class, Action.class.php; if procedural .subs.php. Templates: (same themes/default/) .template.php.
(10:28:49 PM) Norv: (oops, sorry, Admin wasn't a good example, any other will do)
(10:30:36 PM) Norv: There are no namespaces, and the names with _controller exclude duplicates. Also I think they look good.
(10:32:05 PM) Norv: Did the choice surprise you? I think it was obvious, coming from .template and -Subs and .[language].
(10:38:12 PM) Norv: As for directories, if we dont split them per pattern, I'm not sure how else. Because per component wasn't acceptable to people (they found extremely confusing and ugly); templates and languages are already this way and have to be; and they're too many to be kept together IMO. Again, for addons, it'd show what's supposed to be where.
(10:42:18 PM) Norv: (help them a bit do their own separation, or so I hope. Big addons [sub-sites] would have more of each, presumably similar sub-folders, and organizing them this way would IMHO help design them, and keep them easy to find/read)
(10:45:52 PM) TimeVortex: You're quite right, it does make them very easy to recognise, of course.
(10:46:39 PM) TimeVortex: It's just that it looks a bit... double, when you're in an editor that says "......./controllers/PersonalMessages.controller.php" at the bottom.
(10:47:08 PM) TimeVortex: But I guess most editors these days just show the file name in a tab at the top
(10:47:27 PM) ***TimeVortex still hinges on vim most of the time
(10:47:34 PM) TimeVortex: Flirting with SublimeText, though
(11:01:47 PM) ***Norv sighs. I guess someone needs this too. https://googledrive.com/host/0B6LMD0u8OhYYZEotN2QyR1hwR1k/vi-addict.html

(10:53:43 PM) ***Norv likes it when the Eclipse tree shows /controllers and the file name is .controller.php and the contents is doing the right thing. *nods*
(10:55:10 PM) Norv: Nah, tbh, I don't like it when looking at Recent.controller.php ............ :( The above was the goal.......
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #371
(07/21/2013 12:07:22 AM) elk_core: [Elkarte] emanuele45 opened pull request #728: Send ajax (master...send_ajax)  http://git.io/69xPjQ

(12:09:43 AM) groundup: My inbox was completely full of Elkarte Github notificatins. I had to stop watching it because of all the activity. That's a good thing :)
(12:10:57 AM) emanuele: Did you stop today?
(12:11:10 AM) emanuele: Because today Spuds was in a very good mood! xD
(12:11:12 AM) groundup: Yeah
(09:23:56 AM) Norv: groundup: you can choose in your notifications settings to not send email, only web updates.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #372
(09:37:22 AM) elk_core: [Elkarte] eurich opened pull request #729: removed old variant, they are completely broken.. (master...old_variants)  http://git.io/34oaew

(09:54:25 AM) elk_core: [Elkarte] norv merged pull request #724: Elk is a no rodent software (master...norodents)  http://git.io/zlzBcg

(10:11:23 AM) elk_core: [Elkarte] eurich opened pull request #730: Guest can't "mark all messages as read", let's hide the button. (master...markread)  http://git.io/XRDQvA
(10:17:44 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/6WO9ww
(10:17:44 AM) elk_core: Elkarte/master 4a7b6e3 Thorsten Eurich: Guest can't "mark all messages as read", let's hide the button. Fixes #725...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #373
(12:01:50 PM) Norv: > (07:10:48 PM) TimeVortex: "My account" linking to PMs feels a bit weird atm.
(12:01:50 PM) Norv: > (07:11:16 PM) TimeVortex: I suppose that'll relax if those areas (and menus) are merged? Not sure what the plan is.
(12:01:50 PM) Norv: Do you mean, "My Account" should either not link to PMs, either PMs area (pages) would share the same sidebar and all, become a single area with account stuff?
(12:03:41 PM) Norv: (I just realized that maybe that's what you meant. I had the same feeling on admin/mod.)
(12:36:13 PM) TimeVortex: That is what I meant, yeah.
(12:49:01 PM) Norv: Areas weren't meant to be merged, and I don't see how they could be, without becoming far too overloaded. I think what happened was that Ant killed a little too many buttons. Main 4 buttons leading to entire areas with subpages should probably be separated in the menu.
(12:50:09 PM) Norv: Even admin and mod... which overlap sometimes, on some subactions are very different. Mod center and admin center, still separate, makes sense IMHO.
(12:51:05 PM) Norv: YMMV... still, admin is full enough of stuffs lol.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #374
(10:59:15 PM) elk_core: [Elkarte] emanuele45 opened pull request #733: Maybe have the sort by things in a dropdown? (master...sort_drop)  http://git.io/TuHTng

(10:23:22 PM) ***emanuele goes search what standardTime contains... lol
(10:24:01 PM) emanuele: so just a call to standardTime, right?
(10:29:40 PM) TimeVortex: Well, for the relevant poster_time, yeah.

(11:12:47 PM) elk_core: [Elkarte] emanuele45 opened pull request #734: Quick-fix for an undefined index - Thanks Aaron (master...quick_fix)  http://git.io/gVO4AQ

(11:18:03 PM) TimeVortex: emanuele: isn't the first argument for standardTime a boolean?
(11:18:39 PM) TimeVortex: (I like how it sounds semi-sarcastic, btw. "Oh, we have an undefined index. Thanks, Aaron.")
(11:20:37 PM) emanuele: sorry, it didn't intend to be like that... :(
(11:23:39 PM) TimeVortex: emanuele: haha, no, really, I like how it's phrased

(11:22:41 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/0lLXiQ
(11:22:41 PM) elk_core: Elkarte/master b5b2e58 Norv: Fix repair boards for polls missing topics....
(11:22:41 PM) elk_core: Elkarte/master 16b9000 Norv: Reports on boards permissions used the wrong conditions....
(11:22:41 PM) elk_core: Elkarte/master 271dc66 Norv: Use the db method on them smileys....

(11:23:03 PM) emanuele: At least my push -f arrived before Norv! :P
(11:23:19 PM) emanuele: Nope, the first is the time, then two booleans for today and something else...

(11:27:17 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/OsFKug
(11:27:17 PM) elk_core: Elkarte/master 4fd4b3a emanuele: Quick-fix for an undefined index - Thanks Aaron for suggesting the fix...
The best moment for testing your PR is right after you merge it. Can't miss with that one.