Skip to main content
Topic: IRC (Read 58567 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: IRC

Reply #375

(11:52:34 PM) ***Norv is not a fan of smileys sets and message icons area.
(11:56:03 PM) emanuele: I'm not sure how many people actually use more than one (custom) smiley set
(07/22/2013 12:16:47 AM) Norv: For all I saw, I'm under the impression that few people are users, but those are real fans. :)

(12:18:27 AM) elk_core: [Elkarte] norv pushed 8 new commits to master: http://git.io/GguE6w
(12:18:27 AM) elk_core: Elkarte/master 709d9cc Thorsten Eurich: function name was changed, let's use the new name....
(12:18:27 AM) elk_core: Elkarte/master 145ad2b Thorsten Eurich: blank line...
(12:18:27 AM) elk_core: Elkarte/master f0bd976 Thorsten Eurich: global wasn't used....

(02:14:14 PM) elk_core: [Elkarte] norv opened pull request #738: Tweaks and cleaning (master...qfix)  http://git.io/T37AqA
The best moment for testing your PR is right after you merge it. Can't miss with that one.

 

Re: IRC

Reply #376
(06:31:10 PM) elk_core: [Elkarte] emanuele45 opened pull request #740: A new class to handle "positioning" and its use in the poster area (master...expandable_profile)  http://git.io/t6RLyg

(06:45:12 PM) emanuele: Norv: have fun with my last PR! :P

(07:09:17 PM) elk_core: [Elkarte] norv synchronize pull request #738: Tweaks and cleaning (master...qfix)  http://git.io/T37AqA
(07:13:32 PM) elk_core: [Elkarte] norv synchronize pull request #738: Tweaks and cleaning (master...qfix)  http://git.io/T37AqA
(07:28:54 PM) ***emanuele feels the bot is going crazy...
(07:29:42 PM) Norv: Sorry! No, my bad. I am going crazy with Geany.
(07:30:07 PM) Norv: It keeps thinking it knows better, that we *have* to have an extra darned newline!
(07:30:14 PM) Norv: lol
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #377
(07:56:46 PM) Norv: emanuele: oh. What do you have in mind, sections to add to the template?
(08:21:28 PM) emanuele: Not really, at the moment I'm trying to have a better control over few areas (including "button strips" and alike) and a (hopefully) better ways to extend those areas


(08:28:14 PM) Norv: Ehh. What can be in $user_profile which isn't linked to member_id?
(08:30:06 PM) emanuele: I'm totally confused by all these $user_{something} variables...
(08:30:22 PM) emanuele: Well... I'm more confused by their usage
(08:30:40 PM) emanuele: (i.e. when to use one and when to use another)
(08:31:12 PM) emanuele: $user_settings, $user_info, $user_profile, $memberContext
(08:32:08 PM) emanuele: http://www.elkarte.net/index.php?topic=459.0
(08:49:27 PM) Norv: yes. Inter's function way is a good idea... but I'm still wondering if we move that way, if it involves many changes with little benefit
(08:52:11 PM) Norv: The point is, if we try to centralize the information on user, and ask for it from everywhere else, we will be forced to also clean up the various user variables. If all or most the code uses functions, then those functions are a black box where we can make one or more classes with what we really need and dump the rest.
(09:03:32 PM) Norv: emanuele: Re: the topic. I suspect, for example, that password_salt is not in $user_info. And that's ok if we think that there's no need to carry it around, less error prone for one.
(09:04:11 PM) Norv: (I'm looking at ManageServer use of $user_settings)
(09:52:04 PM) Norv: Anyway, if the user isn't really created (or is being recreated), can't use $user_info. It isn't formed, or not reliable
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #378
(12:01:38 AM) elk_core: [Elkarte] norv merged pull request #728: Send ajax (master...send_ajax)  http://git.io/69xPjQ

(07:48:35 PM) elk_core: [Elkarte] norv pushed 8 new commits to master: http://git.io/Z-euRw
(07:48:35 PM) elk_core: Elkarte/master e9e2aa9 Norv: Remove show_board_desc, it's default behavior to show descriptions....
(07:48:35 PM) elk_core: Elkarte/master 5b47e14 Norv: Remove option 'show_children'....
(07:48:35 PM) elk_core: Elkarte/master 976127b Norv: Cleanup conditions on display avatars....

(09:00:20 PM) elk_core: [Elkarte] norv merged pull request #688: This makes nicer the handling of layers in case of errors (master...fatal_errors)  http://git.io/lVPing
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #379
(10:23:42 PM) elk_core: [Elkarte] norv merged pull request #694: Security checks (master...security_checks)  http://git.io/3zckQQ

(10:36:42 PM) Norv: Erm. Are you *sure* you want the BoardsManage-type of names, I mean reversed...? lol.
(10:37:10 PM) emanuele: As I said...who cares... :P
(10:39:14 PM) ***Norv is having second thoughts on the affected files and followup changes... Mkay I'm moving a bit more, but yeah, thinking to limit it at ManageBoards.controller
(07/24/2013 12:41:23 AM) Norv: Hmm. https://github.com/norv/elkarte/tree/rename_admin2/sources/admin
(12:44:01 AM) Norv: https://github.com/norv/elkarte/tree/rename_admin2/themes/default (a few Manage added)
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #380
(10:40:30 PM) elk_core: [Elkarte] AaronVanGeffen opened pull request #745: The mysql_* functions are deprecated per PHP 5.5; let's switch to mysqli_*. Needs testing! (master...master)  http://git.io/XrYblA
(10:43:03 PM) TimeVortex: ^ I almost forgot to sign off, Norv. Almost!
(11:13:19 PM) Dragooon: I broke my mouse :'(
(07/25/2013 12:36:50 AM) Norv: TimeVortex: thank you! (mmm, double thanks, since it seems I forget too O:-))
The best moment for testing your PR is right after you merge it. Can't miss with that one.