Skip to main content ↑ ↓
wrong direction of images Started by Jorin · · Read 15423 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

wrong direction of images

Look at the attachments here please:

http://forum-alternative-antriebe.de/index.php/topic,6042.msg96948.html#msg96948

They are shown in their correct direction. If you click on a thumbnail to see the original size of the image the picture will be turned somehow.

I think this has something to do with apple devices[1]. Is there any way to fix this?
1 Again... Let's spend some bucks so Emanuele can buy an older iPhone!↵

Re: wrong direction of images

Reply #1 –

I think I have an account there, right? (Since the link you posted is registered only.)

 emanuele looks around for the password. xD
Bugs creator.
Features destroyer.
Template killer.

Re: wrong direction of images

Reply #2 –

Yes, you have. Do you need a new password?

You (and others) can use this account:

username: ---
password: ---

I will change the password from time to time to prevent spam.

Changed the account...

Re: wrong direction of images

Reply #3 –

I have not looked at the pictures but I'll describe the issue as I did Here

Apple saves images with an "orientation flag" indicating what direction and which camera front/back.  Now they could have auto corrected the saved image and saved the internet a bunch of headaches, but they wanted to say how much faster their phone was a shooting pictures then others, and you can't be fast if you are doing the corrections.  Instead they tossed it out to the internet to take care of and so began years of wrong orientation images. 

In an effort to help, folks would edit the image and rotate them, but the programs doing so did not know about the new orientation flag, so it would remain set even though the image was now correct.  That image when shown on a system that understood the orientation flag would be rotated the wrong direction but appear correct on an older system, brilliant!

Elkarte does attempt to correct for the orientation flag but requires that you use ImageMagick instead of GD (setting in your ACP).  Also I remember opening a bug report, or maybe a discussion here, where there were some cases when that process was not called,  it may have been for images under a certain size or something, but I can' remember right now ... to early, need more coffee



Last Edit: October 18, 2016, 07:32:52 am by Spuds

Re: wrong direction of images

Reply #4 –

Quote from: Spuds – I have not looked at the pictures but I'll describe the issue as I did Here

Oh, sorry.

Quote from: Spuds – Elkarte does attempt to correct for the orientation flag but requires that you use ImageMagick instead of GD (setting in your ACP).

Hm, I can't find the point to edit the setting in my ACP.  O:-)  The search box in my ACP didn't find anything, and me too.

Re: wrong direction of images

Reply #5 –

Found the issue that I recalled on this .. https://github.com/elkarte/Elkarte/issues/2404

Since your thumbnails are correct, the code ran when it created them and corrected the orientation.  However the full images themselves were not changed (resized nor re-encoded) so they were left "as taken".   The issue above notes that the orientation code will not get run in all cases when in fact it should ... call it a bug if you like.

Re: wrong direction of images

Reply #6 –

Okay, then we call it an apple bug! rofl

Thanks for the help, though there isn't any solution. I will inform my members to check the orientation of attachments made with apple devices.

Re: wrong direction of images

Reply #7 –

xref:
Quote from: https://github.com/elkarte/Elkarte/issues/2404Considering also this:
http://www.elkarte.net/community/index.php?topic=4068.msg29112#msg29112
what would you think about moving this out to 2.0 and write up a "small" (maybe large, who knows LOL) javascript thingy to let the user decide the rotation when uploading the picture?
Something like:
1) upload,
2) small preview (or big if the flag is detected),
3) if the flag is detected, a pair of "rotate +90°"/"rotate -90°",
4) once the rotation is confirmed post it to the server and let IM do its magik.
Bugs creator.
Features destroyer.
Template killer.
 

Re: wrong direction of images

Reply #8 –

Maybe a nice feature for 2.0.   I'd still like to see us fix the processing "path" for 1.1 so the existing code fires every time as I feel it will be correct >95% of the time.

Re: wrong direction of images

Reply #9 –

If you need an example: http://forum-alternative-antriebe.de/index.php/topic,6943.0.html

Still have problems with this thingy. Avatar images, attached images... Often in the wrong direction because a lot of my users seem to use Apple devices. A solution for 1.1 would be really great!

Re: wrong direction of images

Reply #10 –

A solution for 1.0.x already exists, it was introduced into the core of elkarte since 1.0.10. Have you enabled in ACP > Forum > Attachments and avatars > Attachment Settings -> Detect and fix improperly rotated images ?

You can do a test using these images: https://github.com/recurser/exif-orientation-examples
sorry for my bad english

Re: wrong direction of images

Reply #11 –

No, I hadn't. Don't know this option is available now within 1.0.10.  :-[

I activated it now, but the images are still false rotated. Does it work only with new attached images?

Re: wrong direction of images

Reply #12 –

Yes, only with newer images since they are rotated during upload.
sorry for my bad english

Re: wrong direction of images

Reply #13 –

Ah, okay. Thanks, I will test it.

Re: wrong direction of images

Reply #14 –

Here's an example. With my Chrome the thumbnail is false rotated, the full image is correct. With my IE in my office both the thumbnail AND the full image is not correct!  :-X

http://forum-alternative-antriebe.de/index.php/topic,7062.msg117144.html#msg117144

So we still have a problem with the wrong direction of images.