Skip to main content
Code Prettify CSS Started by Spuds · · Read 4308 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

Code Prettify CSS

Playing around and wanted to see how folks feel about using a different skin for when code blocks are used.  Right now (when the option is enabled) we use just a default skin, but its rather bland IMO.  So as a test:

Code: [Select]
<?php

/**
 * This, as you have probably guessed, is the crux for all functions.
 * Everything should start here, so all the setup and security is done
 * properly.
 *
 * @name      ElkArte Forum
 * @copyright ElkArte Forum contributors
 * @license   BSD http://opensource.org/licenses/BSD-3-Clause
 *
 * This software is a derived product, based on:
 *
 * Simple Machines Forum (SMF)
 * copyright:  2011 Simple Machines (http://www.simplemachines.org)
 * license:       BSD, See included LICENSE.TXT for terms and conditions.
 *
 * @version 1.0.9
 *
 */

$forum_version = 'ElkArte 1.0.9';
define('FORUM_VERSION', $forum_version);

// First things first, but not necessarily in that order.
define('ELK', 1);

// Shortcut for the browser cache stale
define('CACHE_STALE', '?109');

if (function_exists('set_magic_quotes_runtime'))
   @set_magic_quotes_runtime(0);
error_reporting(E_ALL | E_STRICT);
$time_start = microtime(true);

// Turn on output buffering.
ob_start();

// We don't need no globals.
foreach (array('db_character_set', 'cachedir') as $variable)
   if (isset($GLOBALS[$variable]))
      unset($GLOBALS[$variable], $GLOBALS[$variable]);

// Ready to load the site settings.
require_once(dirname(__FILE__) . '/Settings.php');

// Directional only script time usage for display
if (!empty($db_show_debug) && function_exists('getrusage'))
   $rusage_start = getrusage();

// Make sure the paths are correct... at least try to fix them.
if (!file_exists($boarddir) && file_exists(dirname(__FILE__) . '/agreement.txt'))
   $boarddir = dirname(__FILE__);
if (!file_exists($sourcedir . '/SiteDispatcher.class.php') && file_exists($boarddir . '/sources'))
   $sourcedir = $boarddir . '/sources';

// Check that directories which didn't exist in past releases are initialized.
if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache'))
   $cachedir = $boarddir . '/cache';
if ((empty($extdir) || !file_exists($extdir)) && file_exists($sourcedir . '/ext'))
   $extdir = $sourcedir . '/ext';
if ((empty($languagedir) || !file_exists($languagedir)) && file_exists($boarddir . '/themes/default/languages'))
   $languagedir = $boarddir . '/themes/default/languages';

// Time to forget about variables and go with constants!
DEFINE('BOARDDIR', $boarddir);
DEFINE('CACHEDIR', $cachedir);
DEFINE('EXTDIR', $extdir);
DEFINE('LANGUAGEDIR', $languagedir);
DEFINE('SOURCEDIR', $sourcedir);
DEFINE('ADMINDIR', $sourcedir . '/admin');
DEFINE('CONTROLLERDIR', $sourcedir . '/controllers');
DEFINE('SUBSDIR', $sourcedir . '/subs');
unset($boarddir, $cachedir, $sourcedir, $languagedir, $extdir);

// Files we cannot live without.
require_once(SOURCEDIR . '/QueryString.php');
require_once(SOURCEDIR . '/Session.php');
require_once(SOURCEDIR . '/Subs.php');
require_once(SOURCEDIR . '/Errors.php');
require_once(SOURCEDIR . '/Logging.php');
require_once(SOURCEDIR . '/Load.php');
require_once(SUBSDIR . '/Cache.subs.php');
require_once(SOURCEDIR . '/Security.php');
require_once(SOURCEDIR . '/BrowserDetector.class.php');
require_once(SOURCEDIR . '/ErrorContext.class.php');
require_once(SUBSDIR . '/Util.class.php');
require_once(SUBSDIR . '/TemplateLayers.class.php');
require_once(SOURCEDIR . '/Action.controller.php');

// Forum in extended maintenance mode? Our trip ends here with a bland message.
if (!empty($maintenance) && $maintenance == 2)
   display_maintenance_message();

// Clean the request.
cleanRequest();

// Initiate the database connection and define some database functions to use.
loadDatabase();

// It's time for settings loaded from the database.
reloadSettings();

// Our good ole' contextual array, which will hold everything
$context = array();

// Seed the random generator.
elk_seed_generator();

// Before we get carried away, are we doing a scheduled task? If so save CPU cycles by jumping out!
if (isset($_GET['scheduled']))
{
   require_once(CONTROLLERDIR . '/ScheduledTasks.controller.php');
   $controller = new ScheduledTasks_Controller();
   $controller->action_autotask();
}

// Check if compressed output is enabled, supported, and not already being done.
if (!empty($modSettings['enableCompressedOutput']) && !headers_sent())
{
   // If zlib is being used, turn off output compression.
   if (ini_get('zlib.output_compression') >= 1 || ini_get('output_handler') == 'ob_gzhandler')
      $modSettings['enableCompressedOutput'] = 0;
   else
   {
      @ob_end_clean();
      ob_start('ob_gzhandler');
   }
}

// Register an error handler.
set_error_handler('error_handler');

// Start the session. (assuming it hasn't already been.)
loadSession();

// Restore post data if we are revalidating OpenID.
if (isset($_GET['openid_restore_post']) && !empty($_SESSION['openid']['saved_data'][$_GET['openid_restore_post']]['post']) && empty($_POST))
{
   $_POST = $_SESSION['openid']['saved_data'][$_GET['openid_restore_post']]['post'];
   unset($_SESSION['openid']['saved_data'][$_GET['openid_restore_post']]);
}

// Pre-dispatch
elk_main();

// Call obExit specially; we're coming from the main area ;).
obExit(null, null, true);

/**
 * The main dispatcher.
 * This delegates to each area.
 */
function elk_main()
{
   global $modSettings, $user_info, $topic, $board_info, $context;

   // Special case: session keep-alive, output a transparent pixel.
   if (isset($_GET['action']) && $_GET['action'] == 'keepalive')
   {
      header('Content-Type: image/gif');
      die("\x47\x49\x46\x38\x39\x61\x01\x00\x01\x00\x80\x00\x00\x00\x00\x00\x00\x00\x00\x21\xF9\x04\x01\x00\x00\x00\x00\x2C\x00\x00\x00\x00\x01\x00\x01\x00\x00\x02\x02\x44\x01\x00\x3B");
   }

   // We should set our security headers now.
   frameOptionsHeader();
   securityOptionsHeader();

   // Load the user's cookie (or set as guest) and load their settings.
   loadUserSettings();

   // Load the current board's information.
   loadBoard();

   // Load the current user's permissions.
   loadPermissions();

   // Load BadBehavior before we go much further
   loadBadBehavior();

   // Attachments don't require the entire theme to be loaded.
   if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach' && (!empty($modSettings['allow_guestAccess']) && $user_info['is_guest']))
      detectBrowser();
   // Load the current theme.  (note that ?theme=1 will also work, may be used for guest theming.)
   else
      loadTheme();

   // Check if the user should be disallowed access.
   is_not_banned();

   // If we are in a topic and don't have permission to approve it then duck out now.
   if (!empty($topic) && empty($board_info['cur_topic_approved']) && !allowedTo('approve_posts') && ($user_info['id'] != $board_info['cur_topic_starter'] || $user_info['is_guest']))
      fatal_lang_error('not_a_topic', false);

   $no_stat_actions = array('dlattach', 'findmember', 'jsoption', 'requestmembers', 'jslocale', 'xmlpreview', 'suggest', '.xml', 'xmlhttp', 'verificationcode', 'viewquery', 'viewadminfile');
   call_integration_hook('integrate_pre_log_stats', array(&$no_stat_actions));

   // Do some logging, unless this is an attachment, avatar, toggle of editor buttons, theme option, XML feed etc.
   if (empty($_REQUEST['action']) || !in_array($_REQUEST['action'], $no_stat_actions))
   {
      // I see you!
      writeLog();

      // Track forum statistics and hits...?
      if (!empty($modSettings['hitStats']))
         trackStats(array('hits' => '+'));
   }
   unset($no_stat_actions);

   // What shall we do?
   require_once(SOURCEDIR . '/SiteDispatcher.class.php');
   $dispatcher = new Site_Dispatcher();

   // Show where we came from, and go
   $context['site_action'] = $dispatcher->site_action();
   $context['site_action'] = !empty($context['site_action']) ? $context['site_action'] : (isset($_REQUEST['action']) ? $_REQUEST['action'] : '');
   $dispatcher->dispatch();
}

What do you think about a style like that

Re: Code Prettify CSS

Reply #1

I like it and I like the option to enable or disable such a feature, because not all forums will use it. 
sorry for my bad english

Re: Code Prettify CSS

Reply #2

This is just theme CSS though. I thought you were talking about this: https://www.browserling.com/tools/css-prettify

Was wondering what that had to do with Elk. :P

As long as it's easy to change so anyone can customise it, use wotcha like.

However, personally I'm not that keen on trying to effectively morph a dark theme into a light theme. It may look terribly exciting at first glance, but IMO it's not as easy on the eyes overall (meaning the ultra high contrast between it and the surroundings is not that groovy for human eyes).
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

 

Re: Code Prettify CSS

Reply #3

Yup this is only CSS, and its one of several "skins" that is available, if you consider about 10-15 lines of css a skin.  It is included with the google prettify package and is actually a standard color palette from VIM.

Interesting comment on it not being as easy on the eyes, all of my IDE's use a dark skin as I find that a lot easier to code in than a light based one.  But then when I view a web site or for reading I much prefer a light variant. 

I guess its just all of the colors in use in the IDE that makes me want to use the darker one, the increased contrast, for me at least, is more pleasing and makes it quicker to review.
Last Edit: February 27, 2017, 08:02:26 pm by Spuds

Re: Code Prettify CSS

Reply #4

Yeah I use a dark skin for coding as well, but generally prefer light skins for sites. Sometime I like a dark skin on a site, but the catch is when switching from one site to another. If my eyes are adjusted for a dark theme, switching tabs to a site with a light theme just about lasers my retinas. Dark themes are also less tolerant of lighting variations. But if I'm just on one site at night in a dimly lit room, a dark theme can be very nice.

What I usually do when anyone posts a code block online is to copy/paste it to Notepad++. I find it much easier to review it that way. IMO online code blocks are pretty much just a way to swap code, not to actually read it.

Anyway if this stuff is only 10-15 lines it should be easy to override in UserContent.css, for anyone using Firefox or Pale Moon. I think (not sure) Chrome might support UserContent.css too. I know IE doesn't, but who cares.
Last Edit: February 27, 2017, 09:13:14 pm by Antechinus
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Code Prettify CSS

Reply #5

IMG_1484.PNG

This is how it looks on mobile

Re: Code Prettify CSS

Reply #6

I had set the theme back to a light variant (from the dark test one), but I did tweak the colors just a bit.  

Actually looks pretty good on mobile, thanks for the image.

Re: Code Prettify CSS

Reply #7

The attached one is the color scheme I'm used to. :P
Bugs creator.
Features destroyer.
Template killer.

Re: Code Prettify CSS

Reply #8

Explains a lot ... really  :P