[1.1.3] inline images with full size

Topic: [1.1.3] inline images with full size (Read 384 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.

[1.1.3] inline images with full size

June 01, 2018, 09:01:32 am

I attached an image and want it to be shown inline in my post. So I used the new function with size=full and alignment=none. Result: the image is shown in thumbnail size.

See: https://www.elkarte.net/community/index.php?topic=1450.msg37497#msg37497

Re: [1.1.3] inline images with full size

Reply #1 – June 01, 2018, 02:57:24 pm

This is another bug ... and maybe an inconsistency.

open ila.integrate.php (sources/subs) and comment out line 399 which says

Code: [Select]

$num .= !empty($modSettings['attachmentThumbnails']) ? ';thumb' : '';

I think the original ILA would show thumbnails for plain [attach]...[/attach] tags. Now to get a thumbnail you have to specify [attach type=thumb]...[/attach] or maybe it was always that way, its been so long I can't remember

The other bug/problem was that it was still showing the "normal" below the post thumbnail (when using just the plain attach tag), commenting out the above line fixes both issues.

Re: [1.1.3] inline images with full size

Reply #2 – June 04, 2018, 08:47:44 am

I don't have this line in my file. And it ins not in my ILA.subs.php too.

Re: [1.1.3] inline images with full size

Reply #3 – June 04, 2018, 02:26:17 pm

LOL .. looks like @emanuele and I are fighting over the same chunk of code

That was part of an 1.1.4 fix that I then changed another way.

Anyway, same line 399 ... you will find ;thumb towards the end, just remove that and give it a test.

Re: [1.1.3] inline images with full size

Reply #4 – June 04, 2018, 02:32:31 pm

Looking at the original bug report and this report they are related but I'm not sure what the correct ILA behavior is.

Currently in 1.1.4 [attach]some image[/attach] will always show a full size image inline. To see a thumbnail you have to use type-thumb in the tag. If this is a problem we need to discuss here and not at 1.1.5

Re: [1.1.3] inline images with full size

Reply #5 – June 04, 2018, 06:54:10 pm

YAY! Fighting!

Re: [1.1.3] inline images with full size

Reply #6 – June 04, 2018, 08:18:47 pm

Don't tell me you will make a convertor or a script to allow to use the old ila bbcodes on elkarte 1.1. I've edited about 500 messages manually

Just kidding and sorry for the OT

Re: [1.1.3] inline images with full size

Reply #7 – June 04, 2018, 09:08:17 pm

I would love that and I would pay a little for it too.

Re: [1.1.3] inline images with full size

Reply #8 – July 05, 2018, 09:59:59 am

Can you provide a fix here?

https://www.elkarte.net/community/index.php?topic=5331.0

Would be much better to show the pictures in full size...

Re: [1.1.3] inline images with full size

Reply #9 – July 05, 2018, 11:02:13 am

You mean in that specific topic?
Change:

Code: [Select]

[attach type=thumb]6057[/attach]

to:

Code: [Select]

[attach type=image]6057[/attach]

Re: [1.1.3] inline images with full size

Reply #10 – July 05, 2018, 11:08:11 am

Yes, thank you!