ElkArte Community Modern, Free, Powerful
Community building forum software

Quote from: Spuds – February 18, 2019, 11:36:08 amDid it indicate which line the error is on?

Quote from: Spuds – February 18, 2019, 06:35:31 pmHummm .... try adding the following line just above that line ( in ManaageAttachments.controller.php )

Code: [Select]

					$modSettings['attachmentUploadDir'] = !empty($modSettings['attachmentUploadDir']) ?: array();

and lets see what happens

Quote from: emanuele – February 19, 2019, 02:24:29 amMaybe...
Line 190:

Code: [Select]

if (isset($this->_req->post->attachmentUploadDir))

to:

Code: [Select]

			if (isset($this->_req->post->attachmentUploadDir) ||
				!empty($this->_req->post->use_subdirectories_for_attachments))

Quote from: Spuds – February 18, 2019, 10:12:13 pmHumm .... this is why @emanuele is updating this code for 2.0

Just for a test, try using

Code: [Select]

					if (empty($modSettings['attachmentUploadDir']))
					{
						$modSettings['attachmentUploadDir'] = array();
					}
					else
					{
						$test = @Util::unserialize($modSettings['attachmentUploadDir']);
						if ($test === false)
						{
							$modSettings['attachmentUploadDir'] = array($modSettings['attachmentUploadDir']);
						}
						else
						{
							$modSettings['attachmentUploadDir'] = $test;
						}
					}

instead of the other single line I gave you.

Quote from: Spuds – February 20, 2019, 06:47:12 pmYeah so the code is a bit broken ....  but I think you know that 

Quote from: Spuds – February 20, 2019, 06:47:12 pmFYI what I personally do is create directories for each year, and I manually create them   I don't really see the need for monthly separation unless you were on a site that created an enormous number of attachments.  I break it down by year just to simplify my backup scripts.

In 2.0 the plan was to simply that code, it simply allows to many options which causes complications for everyone.

Quote from: emanuele – February 21, 2019, 04:52:25 amI think the most common limit to avoid is the usually 10k files per directory that is enforced for ftp in certain configurations (i.e. the ftp returns only the first 10k files). Though this limit is not always present, so it's a kind of case-by-case.
Apart from that, it could be wise to avoid to have more than 10k files in a directory just to remain sane.