Skip to main content
Topic: Send out Newsletter failed (Read 4752 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Send out Newsletter failed

Good morning!
Generally ElkArte send E-Mails. All went well!
But...the attempt send out newsletter (admin;area=news;sa=mailingsend) failed. Return in a blank page.
At the moment no access to server, therefor not in greater detail. Sorry. 

Regards
NetFlag

Re: Send out Newsletter failed

Reply #1
Thanks NetFlag!

It's a missing require.

In sources/admin/ManageNews.controller.php:
Code: (find) [Select]
			// Get the smelly people - note we respect the id_member range as it gives us a quicker query.
Code: (add) [Select]
			require_once(SUBSDIR . '/News.subs.php');

ETA Fixed locally, will push "soon". ;)
Bugs creator.
Features destroyer.
Template killer.

Re: Send out Newsletter failed

Reply #2
And again, codefix in a great pace. You knows ElkArtes stuff. Neat!

Re: Send out Newsletter failed

Reply #3
But there is still a bug there... lol
https://github.com/emanuele45/Dialogo/commit/255a2a18cb2e51bce9070828158bedef065cfba6

And while I was there, I added also an intermediate page when the news letter is finished to inform of the successful sending:
https://github.com/emanuele45/Dialogo/commit/f74a51143cd617c2e5e9ae727aa396d225b05d0f

technically I think there is a sort of bug that there is no indication that the newsletter was sent to 0 members (in case nobody fits into the conditions), it should be fixed as well.
Bugs creator.
Features destroyer.
Template killer.

Re: Send out Newsletter failed

Reply #4
I can do what I want, loading bar stops at 8,33%. Only the administrator (uid1) receives the mail.    :( 


Re: Send out Newsletter failed

Reply #6
Now Im confused. This is my sources/Subs.php Line 3125 till 3169.
Code: [Select]
	// Output the declared Javascript variables.
if (!empty($context['javascript_vars']) && !$do_defered)
{
echo '
<script><!-- // --><![CDATA[';

$output = array();
foreach ($context['javascript_vars'] as $key => $value)
$output[] = $key . ' = ' . $value;

echo '
var ' . implode(",\n\t\t\t", $output) . ';';

echo '
// ]]></script>';
}

// Inline JavaScript - Actually useful some times!
if (!empty($context['javascript_inline']))
{
if (!empty($context['javascript_inline']['defer']) && $do_defered)
{
echo '
<script><!-- // --><![CDATA[';

foreach ($context['javascript_inline']['defer'] as $js_code)
echo $js_code;

echo '
// ]]></script>';
}

if (!empty($context['javascript_inline']['standard']) && !$do_defered)
{
echo '
<script><!-- // --><![CDATA[';

foreach ($context['javascript_inline']['standard'] as $js_code)
echo $js_code;

echo '
// ]]></script>';
}
}
}

No match to yours here on Github.

Re: Send out Newsletter failed

Reply #7
Then probably you are using a version of few days ago and the code is still the old one, then the other one should be enough. ;)
Bugs creator.
Features destroyer.
Template killer.

Re: Send out Newsletter failed

Reply #8
Ah, I was not yet clear about the package get updates. So its me to upgrade my installation.
Have to test a little bit more on weekend.
Thank you Emanuele!

Re: Send out Newsletter failed

Reply #9
Starting from the beta up to now, we didn't change anything on the database, so it is enough to just grab the package and replace the files in order to be up-to-date! :)
Bugs creator.
Features destroyer.
Template killer.

Re: Send out Newsletter failed

Reply #10
Now everything is on the current state here. Test send out newsletter. Elk says all went well:
Quote
You have successfully sent your newsletter!

It is not. Actually still only members of the group Administrator get mails.

Edit:
New evidence. Delivery only fails if user still has no primary membergroup.

Re: Send out Newsletter failed

Reply #11
 emanuele marks this topic unread...
Bugs creator.
Features destroyer.
Template killer.

Re: Send out Newsletter failed

Reply #12
...also failed is user in additional group.   :'(

Re: Send out Newsletter failed

Reply #13
Try this, in admin/ManageNews.controller.php:
Code: (find) [Select]
		// Some functions we will need
require_once(SUBSDIR . '/Mail.subs.php');
Use the comment too because there are two instances of the require_once and only the one with the comment is the important one in that case.
And just after it add:
Code: [Select]
		require_once(SUBSDIR . '/News.subs.php');
Bugs creator.
Features destroyer.
Template killer.

Re: Send out Newsletter failed

Reply #14
Unfortunately not. All groups, expect my new "Newsletter" (2 Members inside) , uncheckt. Nevertheless no one recieved email. That's Greek to me.