Skip to main content ↑ ↓
IRC Started by TestMonkey · · Read 146434 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

Re: IRC

Reply #270 –

Quote from: Arantor –
Quote from: TestMonkey – https://github.com/gnif/SMF2.1/commit/22dd5430dd7b2e8062bfb79c9faa5b7c122da697

Apart from the horrible formatting, you mean?

EDIT: And a bug. (mysqli_num_fields doesn't exist)

How so? http://php.net/manual/en/mysqli-result.field-count.php

TBH I'm glad to see an implementation on mysqli. It should be straightforward to adapt. We'll check out gnif's PR and adapt it.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #271 –

That's weird, when I searched the manual, it couldn't find mysqli_num_fields and pointed me instead to http://php.net/manual/en/mysqli.field-count.php

Also note that the usual search (php.net/mysqli-num-fields) certainly doesn't find it. And the man page for mysql_num_fields() does not mention it either but it does explicitly mention mysqli_field_count(). :/

Re: IRC

Reply #272 –

(10:11:28 PM) elk_core: [Elkarte] norv pushed 47 new commits to master: http://git.io/_nYmiQ
(10:11:28 PM) elk_core: Elkarte/master 546350c Thorsten Eurich: remove bold attribute from the active menu button...
(10:11:28 PM) elk_core: Elkarte/master 6ec4c02 Thorsten Eurich: blue variant: replaced the hover color for the sake of better readability...
(10:11:28 PM) elk_core: Elkarte/master 6cd5e88 Thorsten Eurich: cleaning subs.php, please check the todo remarks.....

(11:43:35 PM) elk_core: [Elkarte] norv pushed 11 new commits to master: http://git.io/WwqpPQ
(11:43:35 PM) elk_core: Elkarte/master 0b9d63e Thorsten Eurich: HTML5, use <abbr> instead of deprecated <acronym>...
(11:43:36 PM) elk_core: Elkarte/master 19c990d Thorsten Eurich: HTML5: bye bye teletubbies...
(11:43:36 PM) elk_core: Elkarte/master 3bb0284 Thorsten Eurich: HTML5: let's use the new  <header>, <nav> and <footer> tags....
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #273 –

(11:52:13 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/mDdKAg
(11:52:14 PM) elk_core: Elkarte/master b98a5a5 emanuele: A function to render uniformly the "pagesection" (i.e. page_index + top/bottom buttons + other buttons) across all the templates...
(11:52:14 PM) elk_core: Elkarte/master 9d95946 Norv: Merge pull request #504 from emanuele45/template_pagesection...

(11:54:49 PM) elk_core: [Elkarte] norv pushed 10 new commits to master: http://git.io/-VriOA
(11:54:49 PM) elk_core: Elkarte/master 9c679f1 Spuds: ! remove shorten_subject and use the more general shorten_text in its place....
(11:54:49 PM) elk_core: Elkarte/master 844454c Spuds: ! add $modSettings 'subject_length' and 'draft_subject_length'...
(11:54:49 PM) elk_core: Elkarte/master b901daf Spuds: ! missed that one call, it should be done as cutword...

(11:59:25 PM) ***emanuele runs git pull elk master
(06/09/2013 12:08:46 AM) Norv: :D
(12:09:00 AM) Norv: I saved your commits!
(12:09:30 AM) emanuele: I saw, thanks!
(12:09:43 AM) emanuele: Though I discovered reflog O:-)
(12:09:55 AM) emanuele: That's a pretty cool thing nods
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #274 –

(12:11:53 AM) emanuele: Now I have to find a way to make the darn buttons work the way I want (provided I find what way I want them to work) and I think I've done everything I wanted to do to the theme

(01:01:47 AM) emanuele: Norv: that's a good one for you! https://github.com/elkarte/Elkarte/commit/27853128ee2070ba975f2401495e3b324a0fcae6
(01:01:49 AM) emanuele: :P
(01:02:12 AM) ***emanuele wonders why the repo history has been cut when forked...
(01:02:48 AM) emanuele: for reference: https://github.com/SimpleMachines/SMF2.1/commit/43a7e709f2bd121993d5b941b3400cb48f809f87
(01:03:37 AM) emanuele: $birthdayEmails was correct as it was because the two cycles are/were (since I'm going to remove them) just for backward compatibility with 2.0
(01:04:14 AM) emanuele: I introduced $txtBirthdayEmails to have a different variable and be able to keep backward compatibility ;)
(01:09:19 AM) Norv: headscratch
(01:09:52 AM) elk_core: [Elkarte] emanuele45 opened pull request #505: Quick fix (master...quick_fix)  http://git.io/1RJL9w
(01:14:26 AM) Norv: Oops, sorry. Mindless c/p be damned.
(01:15:12 AM) emanuele: I don't believe you, you just think you can still win the competition! :P
(01:22:40 AM) Norv: :D
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #275 –

(01:27:32 AM) ***emanuele hates the default avatars
(01:28:28 AM) emanuele: If there is no avatar you are forced to "read" (mostly) the nick, but with a default avatar I tend to look only at the avatar and all the people look the same... >_<

(01:51:59 AM) emanuele: Norv, https://gist.github.com/emanuele45/e95df396adbf7397722a ?

(03:47:18 AM) elk_core: [Elkarte] Spuds opened pull request #506: Mundane tweaks to the formatting (master...formatting)  http://git.io/G0Nr6A
(05:18:37 AM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/BU3iMg
(05:18:38 AM) elk_core: Elkarte/master a307b60 Spuds: ! spacing and formatting...
(05:18:38 AM) elk_core: Elkarte/master 9b8fd76 Spuds: ! spacing and formatting and a couple of excess globals removed...
(05:18:38 AM) elk_core: Elkarte/master 4e95595 Spuds: ! spacing and formatting...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #276 –

(06:03:19 AM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/64u-2w
(06:03:19 AM) elk_core: Elkarte/master 4792345 emanuele: Undefined variable in shorten_text...
(06:03:19 AM) elk_core: Elkarte/master f4d0de4 emanuele: Removed emails backward compatibility code (recently screwed up anyway)...
(06:03:19 AM) elk_core: Elkarte/master f008072 emanuele: Likes settings are needed for admin search to work...

(02:07:08 PM) elk_core: [Elkarte] emanuele45 opened pull request #507: Quick fix (master...quick_fix)  http://git.io/LJHP5g
(03:15:25 PM) elk_core: [Elkarte] emanuele45 pushed 3 new commits to master: http://git.io/cao2iA
(03:15:25 PM) elk_core: Elkarte/master 38be383 emanuele: Wrong logic in layers class...
(03:15:25 PM) elk_core: Elkarte/master 085de6c emanuele: Missing require_once...
(03:15:25 PM) elk_core: Elkarte/master 3c41ebe emanuele45: Merge pull request #507 from emanuele45/quick_fix...

(04:05:02 PM) elk_core: [Elkarte] Spuds opened pull request #508: Update JQ Plugins (master...jqPlugs)  http://git.io/seAyDw

(04:30:51 PM) elk_core: [Elkarte] emanuele45 opened pull request #509: An easier way to add maintenance tasks? (master...extend_maintenance)  http://git.io/M-Vttw

(04:42:36 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/xis2tw
(04:42:36 PM) elk_core: Elkarte/master 23d9047 Spuds: ! Our version of superfish 1.7.2 was missing an iOS update, this fixes that....
(04:42:36 PM) elk_core: Elkarte/master 15a5bdc Spuds: ! Update the editor and bbcode plugin to 1.4.3...
(04:42:36 PM) elk_core: Elkarte/master 0224ae3 Norv: Merge pull request #508 from Spuds/jqPlugs...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #277 –

(11:04:14 PM) Norv: http://www.simplemachines.org/community/index.php?topic=495881.msg3558277#msg3558277
(11:16:22 PM) ***emanuele is tempted to post the commit and say "cherry-pick it" :P
(11:16:40 PM) emanuele: But I'm too busy writing mods for Elk! O:-)
(11:22:36 PM) Norv: Cool stuff :)
(11:26:06 PM) emanuele: Yep, writing addons is becoming funny now! :D

(06:26:35 PM) elk_core: [Elkarte] emanuele45 opened pull request #510: Reworked a bit the css loading to fix Ant's report (master...loading_css)  http://git.io/I-ca8g
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #278 –

(06:26:35 PM) elk_core: [Elkarte] emanuele45 opened pull request #510: Reworked a bit the css loading to fix Ant's report (master...loading_css)  http://git.io/I-ca8g
(05:05:05 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/9wCIxQ
(05:05:05 AM) elk_core: Elkarte/master 99d2f6d emanuele: Reworked a bit the css loading to fix Ant's report http://www.elkarte.net/index.php?topic=412.0...

(01:26:56 AM) elk_core: [Elkarte] emanuele45 opened pull request #511: Quick fix (master...quick_fix)  http://git.io/tWyySA
(03:38:18 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/v4ZABQ
(03:38:18 AM) elk_core: Elkarte/master 7b9b1ed emanuele: Error changing saving theme settings if "allow member to select theme" was disabled...
(03:38:18 AM) elk_core: Elkarte/master 5fb5a5a emanuele: javascript values could even be zero! :P...

(05:06:23 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/d8a5fw
(05:06:23 AM) elk_core: Elkarte/master 083ad4c emanuele: An easier way to add maintenance tasks?...
(05:06:23 AM) elk_core: Elkarte/master cbc23d4 emanuele: Tries to use a fallback (plain function) if the activity method doesn't extis (i.e. activities added via hooks)...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #279 –

(04:01:12 PM) emanuele: Norv: is theme and look&feel compatibility with SMF so important to us?

(06:00:21 PM) groundup: emanuele, what file is that display callback in? Just looking on Github
(06:04:17 PM) emanuele: Display.controller.php is where the query is run
(06:04:26 PM) emanuele: Display.template.php is where the callback is called

(07:56:49 PM) groundup: WTF is with this error message "Deleting just any posts in this board is not allowed."
(07:57:03 PM) groundup: It's confusing English

(05:38:11 AM) elk_core: [Elkarte] norv opened pull request #512: Picks (master...picks)  http://git.io/_df_Ew
(05:38:34 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/XZ8ooQ
(05:38:34 AM) elk_core: Elkarte/master aca3c90 Illori: Moderator Help Issue...
(05:38:34 AM) elk_core: Elkarte/master be4ccba Colin Schoen: Minor language corrections...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #280 –

Quote from: TestMonkey – (04:01:12 PM) emanuele: Norv: is theme and look&feel compatibility with SMF so important to us?

Not if you feel differently. IMHO: experiment design.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #281 –

(09:53:31 PM) emanuele: mmm...
(09:54:04 PM) emanuele: Norv, what do you think about git submodules for addons and themes at github?
(09:54:41 PM) emanuele: I was testing it right now, though they remain basically independent...dunno if it is a nice effect or not
(09:55:03 PM) Norv: sure, we could do that
(09:55:58 PM) emanuele: In fact submodules are just a sort of placeholder if I understand correctly
(09:56:10 PM) emanuele: https://github.com/emanuele45/Elk_addons/tree/master/addons
(09:56:25 PM) emanuele: redirect in case of github

(10:03:27 PM) elk_core: [Elkarte] eurich opened pull request #515: Controllers refactoring (master...controllers)  http://git.io/dg0PEg

(11:22:32 PM) Norv: I think it's very nice, the best way to both keep them separate and referenced in a repo
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #282 –

(04:21:29 AM) ***Antechinus like moose
(04:22:43 AM) Antechinus: Btw looks decent in ie8 too
(04:22:45 AM) Antechinus: which is handy
(04:23:08 AM) Antechinus: theme I mean, not moose. Moose good in any browser :P
(04:23:31 AM) Norv: That moose is telling me "fat and stupid", I thought you were joking! I don't think I like it, as logo I mean. I hope Xar's gonna come up with something to take you :P
(04:23:40 AM) Norv: Ah cool
(04:24:07 AM) Antechinus: Hey but Bloc and I both like it
(04:24:13 AM) Antechinus: how often do Bloc and I agree?
(04:24:29 AM) Norv: Wow. Too good point. ROFL!!
(04:24:34 AM) Antechinus: Eliana thought cute and cuddly, not fat and stupid
(04:24:54 AM) Antechinus: which is sort of how I feel about it too
(04:24:59 AM) Antechinus: makes me smile
(04:25:13 AM) Antechinus: anyway not a huge deal
(04:25:40 AM) Norv: Well tbh I kinda don't hate as much after looking at it some more. But hey.
(04:26:15 AM) Antechinus: moose haz mind control
(04:26:20 AM) Antechinus: you will be assimilated :P
(04:26:20 AM) Norv: lol
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #283 –

(06/13/2013 12:42:34 AM) emanuele: darn...
(12:43:17 AM) emanuele: I started working on the autosuggest without putting the code in a git repo and now I don't want to add the autosuggest any more and I have to guess where things are... lol
(01:02:29 AM) emanuele: Norv: here it is where I used the new hooks I added the other day http://www.elkarte.net/index.php?topic=423.0
(01:02:31 AM) emanuele: :P
(01:15:45 AM) elk_addons [~elk_addon] entered the room.
(01:15:45 AM) elk_addons: [addons] emanuele45 opened pull request #1: Let's see how submodules work. (master...master)  http://git.io/RW3Y_A
(01:15:45 AM) elk_addons left the room.

(02:12:29 AM) elk_addons: [addons] norv pushed 4 new commits to master: http://git.io/6pNNuA
(02:12:29 AM) elk_addons: addons/master 9a08b84 emanuele: Added tabbed_cats as submodule...
(02:12:29 AM) elk_addons: addons/master a61198a emanuele: Added are_you_human as submodule...
(02:12:29 AM) elk_addons: addons/master 14919b9 emanuele: Added topic_tags as submodule...
The best moment for testing your PR is right after you merge it. Can't miss with that one.
 

Re: IRC

Reply #284 –

(11:57:40 AM) elk_core: [Elkarte] norv pushed 15 new commits to master: http://git.io/WTSvVw
(11:57:40 AM) elk_core: Elkarte/master 535022f Thorsten Eurich: help controller: methods visibility...
(11:57:40 AM) elk_core: Elkarte/master 235e3dc Thorsten Eurich: passed get vars should be cleaned.....
(11:57:40 AM) elk_core: Elkarte/master 14385fa Thorsten Eurich: announce controller: methods visibility...

(10:05:37 PM) emanuele: Does anyone know of a reliable XML validator that takes in consideration also the XSD schema?

(04:35:36 AM) elk_core: [Elkarte] Spuds opened pull request #518: Use of validation class for review / feedback ... Do Not Merge (master...validate)  http://git.io/17keeQ

(03:31:06 PM) elk_core: [Elkarte] emanuele45 opened pull request #523: Fix the all button (and a query) (master...fix_all)  http://git.io/p7cLGw
(12:22:32 PM) elk_core: Elkarte/master cd3d1d0 emanuele: Broken query...
(12:22:32 PM) elk_core: Elkarte/master b26d29d emanuele: Moved the "all" link to constructPageIndex and styled the same as the other buttons...
(12:22:32 PM) elk_core: Elkarte/master 778f6a1 emanuele: Fixed (I think) news fader jumping when collapsed Fixes #522...

(06:36:43 PM) elk_core: [Elkarte] emanuele45 opened pull request #524: That should allow to obtain more meaningful error messages...I hope (master...error_backtrace)  http://git.io/wocFfw
(05:50:59 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/TBxBgQ
(05:50:59 AM) elk_core: Elkarte/master 0efdf89 emanuele: That should allow to obtain more meaningful error messages...I hope...
(05:50:59 AM) elk_core: Elkarte/master d3389b9 Norv: Merge pull request #524 from emanuele45/error_backtrace...
The best moment for testing your PR is right after you merge it. Can't miss with that one.