Skip to main content
Recent Posts
1
Bug Reports / Re: Image preview
Last post by Spuds -
Yeah ... Humm

I was only seeing the low quality image but I'm using imagick in testing, so maybe GD is different (1.1.9). 

The issue stems from those tmp files we use when in preview, they were originally intended for use in the upload area, so they are just 100px thumbnails. When they get ila'ed in preview above 100px they look horrible!

A quick fix to try is in Attachment.controller.php
Code: (find) [Select]
		if ($resize && resizeImageFile($filename, $filename . '_thumb', 100, 100, $format))
Code: (replace) [Select]
		if ($resize && resizeImageFile($filename, $filename . '_thumb', 250, 250, $format, false, false))

That will provide a larger thumbnail image for use while still remaining a very small file so things do not slow down.   Give that a test and let me know, I'm testing it as well.
2
Bug Reports / Image preview
Last post by radu81 -
Not sure if this is a bug, but it's sure strange.

I inserted two attachments, one jpg and one in webp format, then I choose to insert those images inline with 200 px widh. Then I use the preview button and here is what I get:

Elkarte 1.1.9:
- the preview for jpg is in low quality
- the preview for the webp is in good quality

Elkarte 2.0
- both images in preview mode are in low quality

Like I said, not sure if it's a bug and how it was supposed to work the preview, strange is that on Elkarte 1.1.9 the webp image in preview mode is displayed in a good quality. I attach the images I used and the preview I see in both versions.
4
General ElkArte discussions / Re: ElkArte 1.1.9
Last post by Spuds -
I've got it installed on my "robot friendly" site for abuse testing and several other sites.  I did notice a small issue with bad behavior (results in error log spam)  that I'll fix in the final patch. 

I am also going to add a step to patch SP during the install since if you don't update SP before the patch you could end up with a defunct site.   Its not normal to patch an addon, but in this case I think its prudent.

Going to final this weekend is my goal.   I also want this to be done so I can get back to 2.0 !!
8
Theme development / Re: Click to expand quote
Last post by Spuds -
Indeed I reused the string, providing a unique one is a good idea. 

We can just add a new $txt['quote_expand'] = '???; to the same file.  Expand Quote, Show More, Show Entire Quote, Read More or Click to expand all seem like good choices.
10
Theme development / Re: Click to expand quote
Last post by radu81 -
I would like to suggest a minor change for this: add own translation for the text "More". If I am not wrong it uses the same "More" text from here:
2022-11-27_11-35.png
In this way it's much easier to translate. In my case "More" under every post is translated as "Other options" while "More" under the quoted text should be something like "Read more" or "Click to expand".
What do you think?