Skip to main content
Recent Posts
62
Addons / Re: [ADDON] Levertine Gallery
Last post by radu81 -
I believe TIFF files should not be allowed in a web gallery, or at least they should be converted to JPEG/PNG or WebP.
Tif files are mostly used for high quality printing, it's a lossless format, sometimes not even compressed, often in CMYK, could embed colour profile, I really don't know if a cmyk file could be converted to RGB by GD/Imagick and how the results could be. The colours accuracy will surely differ from the original file.
For me it's a no.
64
General ElkArte discussions / Re: Preliminary ElkArte 1.1.10 - Release Notes
Last post by Spuds -
I'm attaching an updated GenericControls.template.php which is in your themes/default directory.

We have a behavior (due to the version of the editor we use) that causes the editor to sometimes move into view when the page loads, and sometimes not, its a bit complicated with browser and editor plugins interaction   ....  and you probably don't even notice :D

Moving the editor into view, I think, is a generally nice.  There are some places where you don't want that to happen, for example quick reply or a comments box below an article as those are not the focus of the page, but modify or reply I think it makes sense.

The other behavior we have is when you go to edit a post (not quick edit but full modify) the post loads and the editor has scrolled to the bottom of the post and places the cursor there.  Its not as noticeable on a short post, but if you have a long post its obvious.

Attached is a proposal that will fix/standardize both behaviors.  The editor will load the message to modify and begin at the start of the message, not the end.  It will also move the editor to the page top (modify/reply/etc) since that is the focus of what you are doing.  So give the below a try, its just one file, save your old one so you can revert, and let me know what you think:thinking:

ETA its in the latest patch file attached in a later post
65
Addons / Re: [ADDON] Levertine Gallery
Last post by Spuds -
You can always use WinMerge to compare the versions .... The above fix was just a few lines added to the (3) .on thumbnail events, two in album and one in item templates.
67
Addons / Re: [ADDON] Levertine Gallery
Last post by Spuds -
The TIF issue was that it showed a broken / no thumbnail in the upload interface, but it the thumbnail complete event was triggering so everything proceeded as normal.

This is really due to poor browser support for TIF images and what is probably a bug in the upload project.  The fix was to show a generic thumbnail when the client fails to create one successfully.   The update works for any client side thumb-nailing that fails so its a good catch net to have in the code.