Skip to main content
Recent Posts
21
Support / Re: "Missing Key" error on reply-email
Last post by Spuds -
You should be able to make outbound adjustments with edits to the Maillist.Templates  to make it what you need.

For the inbound email, that is where the Filters and Parsers come in to play.  The idea is to make what gets posted look like a post and not an email.

Filters run first, and you can do simple find and replace.

Parsers run after Filters and there you can define regex code with the goal of finding either the start of a signature or the start of a quoted message and cut the message at that point.  Of course that only works if they post above the original in the reply.

I have been working on about 6 generic parser regex codes that seem to handle a majority of cases.  I'll post those if interested.
22
Bug Reports / Re: EMail Replies to the EA forum
Last post by Spuds -
I've been working on, somewhat sporadically, the 1.1.x => 2.0 update script to take care of any DB changes and updates.  Without that it will not "like" a 1.1.x db.

I've been doing more work on the parser and found some more edge cases that I fixed, all were mainly all around malformed email,  headers or body text but there were some ways to deal with those with out to much drama.  All the testing was on 2.0,  so up next it to test those changes on 1.1.x and make sure they work as expected there.

Once that is done, I'll post the updates for folks to test out.
23
Bug Reports / Re: EMail Replies to the EA forum
Last post by rjm -
Would be an interesting opportunity. In fact, it is easier for me to swap my test forum from 1.1.8 to 1.1.9 instead of swapping to the 2.0 code base. In the latter case, a missing database table is complained about.
However, until now git fetch origin does not result in updates...
24
Support / Re: "Missing Key" error on reply-email
Last post by rjm -
All posts in general. Just as Steeley wrote: a replacement for a classic distribution list.

BTW: I experienced - since it's operating now - that the post content in the notification email appears quite towards the bottom of the email (v.1.1.8 ).

QuoteSection with two links and then

The text of the reply is shown below:
test
 
 
Regards,
The xxxx-Forum Team.
 
[df84f9b51e556e770d9be6f3d2afe98e-m120]
 
 
 
It would make more sense if the standard stuff would be below the posting content.
I see that in dev. 2.0 the standard stuff is better structured. As such predestined to appear to the bottom.

On top of the notification including a post, only the following text should appear before the posting content:
Quote=== automated email containing the following new posting from xxxx-Forum. You can reply to this posting or post a reply direclty in the forum - hints & links see bottom section ===

I doubt whether it is good or not to send notifications in html-formatted mails (as is the case with dev 2.0.
25
Bug Reports / Re: EMail Replies to the EA forum
Last post by Steeley -
Well alrighty then.  I went up on the board and deleted those three emails to "clean things up".

I'll be looking for the fixes, and hopefully Google doesn't decide in the meantime to implement some new "security/spam/pfishing" Gmail format protocol and try to drive it to the rest of the known universe.

If this posts, you'll know to check your PM for that "other issue" I mentioned.

-Steeley 


Did you exchange, a walk-on part in the war for a lead role in a cage?

[~ Pink Floyd: "Wish You Were Here"]

--
27
Bug Reports / Re: EMail Replies to the EA forum
Last post by Spuds -
Quote from: Steeley – Hopefully it opened up the acceptance criteria rather than narrowed it to Pegasus 4.80!
It should have! ... Found a couple of other bugs but getting "out there" in terms of what the PBE function would expect to get in a reply.   The parser handles a lot of different cases but not all (by design)  TBH I wrote most of that 10 years ago so its showing its patina ;)
Quote from: Steeley – Can you shoot the code changes to me that I can plug into the appropriate 1.1.6 php files?
Yup ... I'll get this all in 1.1.9 and the specific files (I think there are two) should be drop in replacements.

And as a test I released (3) of your reply's back (the ones that the parser used to fail)
28
Bug Reports / Re: EMail Replies to the EA forum
Last post by Steeley -
Hopefully it opened up the acceptance criteria rather than narrowed it to Pegasus 4.80!

Little story: We had a bunch of old Sundstrand low-speed ARINC 429 data loggers that one of our engineers hacked so they would also work on the high-speed 429 buses. Worked great until a few years later when we built the first HF Data Link Radios,. We updated the HF's on a 28 day cycle with new HF Ground Stations as they came on line, and/or changed frequencies. Only they couldn't update in the aircraft, only on the bench for some reason. I found the reason.. the 429 bus had a programming error and was running at "Half-High-speed", in between low-speed and high speed. Our modified data-loggers didn't care, they worked with anything in between 10khz and 100khz. Those that were "compliant with the standards" (low-speed 12-14.5Khz, high speed 100Khz +/- 1%) however, wouldn't work when the bus is running at 50Khz.

I guess as long as the parser will work with  anything coming at it (good bad or ugly), it's all good (and low maintenance to boot). 

Can you shoot the code changes to me that I can plug into the appropriate 1.1.6 php files?

(BTW I just discovered something else with 1.16 that I'll bounce off you a little later - probably via PM.)
29
Bug Reports / Re: EMail Replies to the EA forum
Last post by Spuds -
Well as I did a code:beers::takeout_box:review, I did an experiment that looks to fix this issue (and the previous), and best of all it removes some code :D

Going way back,  improvements were added to properly (cough) work with Multipart/Related messages.  However some old conditions were left in place that had previously been used to, somewhat, work around/circumvent them. 

So when I come around in the AM I'll do a bit more testing, but right now it kind of looks good, at least with @Steeley email's
30
Bug Reports / Re: EMail Replies to the EA forum
Last post by Spuds -
Took a quick look and its again a parser failure, kind of.

The empty messages, as far as the parser was concerned, were shown as Multipart/Related and in those boundaries are a single HTML message, not Multipart/Alternative, just a single HTML message. 

TBH I'm not sure that is compliant, I thought all emails must contain a text/plain section, but we are talking about email here LOL

Now I had put in a catch for messages missing a plain/text section but containing a text/html section.  The issue is that does not run when that is in the Multipart/Related area only when in the Multipart/Alternative section.    Not sure there is a quick work around for that with the current structure of the parser,  may have to refactor that area.